Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecations carried over from 8 #195491

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Update deprecations carried over from 8 #195491

merged 3 commits into from
Oct 9, 2024

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Oct 8, 2024 •
edited by kibanamachine
Loading

Fix #142915

Risk Matrix

Risk Probability Severity Mitigation/Notes
Third party plugin types throw type errors Low Low type checks will error when using a deprecated type. Plugin authors should extend the supported types or define new ones inline

For maintainers

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) v8.16.0 labels Oct 8, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-plugins-server 26 19 -7
Unknown metric groups

API count

id before after diff
@kbn/core-plugins-server 61 53 -8

References to deprecated APIs

id before after diff
@kbn/core 32 31 -1
@kbn/core-plugins-server-internal 10 8 -2
total -3

@TinaHeiligers TinaHeiligers marked this pull request as ready for review October 8, 2024 21:32
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner October 8, 2024 21:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers TinaHeiligers merged commit 5ed13ee into elastic:main Oct 9, 2024
32 checks passed
@TinaHeiligers TinaHeiligers deleted the kbn-142915-cleanup-legacy-deprecations branch October 9, 2024 17:13
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11259805988

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2024
@TinaHeiligers
Update deprecations carried over from 8 (elastic#195491)
14fb681 
Fix elastic#142915

### Risk Matrix

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Third party plugin types throw type errors | Low | Low | type checks
will error when using a deprecated type. Plugin authors should extend
the supported types or define new ones inline |

### For maintainers

- [X] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
(no breaking changes)

(cherry picked from commit 5ed13ee)
@kibanamachine kibanamachine mentioned this pull request Oct 9, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 9, 2024
@kibanamachine @TinaHeiligers
[8.x] Update deprecations carried over from 8 (#195491) (#195654)
358b279 
# Backport

This will backport the following commits from `main` to `8.x`:
- [Update deprecations carried over from 8
(#195491)](#195491)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Christiane (Tina)
Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2024-10-09T17:12:52Z","message":"Update
deprecations carried over from 8 (#195491)\n\nFix
https://github.com/elastic/kibana/issues/142915\r\n\r\n### Risk
Matrix\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Third party plugin types throw type errors | Low | Low | type
checks\r\nwill error when using a deprecated type. Plugin authors should
extend\r\nthe supported types or define new ones inline |\r\n\r\n### For
maintainers\r\n\r\n- [X] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n(no
breaking
changes)","sha":"5ed13ee4a4b4325bae2f3e117a4fc400540fa542","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"Update
deprecations carried over from
8","number":195491,"url":"https://github.com/elastic/kibana/pull/195491","mergeCommit":{"message":"Update
deprecations carried over from 8 (#195491)\n\nFix
https://github.com/elastic/kibana/issues/142915\r\n\r\n### Risk
Matrix\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Third party plugin types throw type errors | Low | Low | type
checks\r\nwill error when using a deprecated type. Plugin authors should
extend\r\nthe supported types or define new ones inline |\r\n\r\n### For
maintainers\r\n\r\n- [X] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n(no
breaking
changes)","sha":"5ed13ee4a4b4325bae2f3e117a4fc400540fa542"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195491","number":195491,"mergeCommit":{"message":"Update
deprecations carried over from 8 (#195491)\n\nFix
https://github.com/elastic/kibana/issues/142915\r\n\r\n### Risk
Matrix\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Third party plugin types throw type errors | Low | Low | type
checks\r\nwill error when using a deprecated type. Plugin authors should
extend\r\nthe supported types or define new ones inline |\r\n\r\n### For
maintainers\r\n\r\n- [X] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n(no
breaking
changes)","sha":"5ed13ee4a4b4325bae2f3e117a4fc400540fa542"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[meta] Remove 7 to 8 deprecated Core API's
5 participants
@TinaHeiligers @elasticmachine @kibanamachine @afharo @jloleysens