Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Security Solution][Notes] - add new notes icon for manage page (#194752) #194844

Merged
merged 1 commit into from
Oct 3, 2024
Merged

[8.x] [Security Solution][Notes] - add new notes icon for manage page (#194752) #194844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...s/security_solution/public/app/solution_navigation/links/sections/investigations_links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*/

import { ExternalPageName, SecurityPageName } from '@kbn/security-solution-navigation';
import IconFilebeatChart from './icons/filebeat_chart';
import { INVESTIGATIONS_PATH } from '../../../../../common/constants';
import { SERVER_APP_ID } from '../../../../../common';
import type { LinkItem } from '../../../../common/links/types';
Expand Down Expand Up @@ -49,7 +48,7 @@ export const updateInvestigationsLinkFromNotes = (
currentLinks.push({
...noteLink,
description: i18n.NOTE_DESCRIPTION,
landingIcon: IconFilebeatChart,
landingIcon: 'filebeatApp',
});
return {
...investigationsLink,
Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/security_solution/public/management/links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import type { CoreStart } from '@kbn/core/public';
import { i18n } from '@kbn/i18n';

import IconFilebeatChart from '../app/solution_navigation/links/sections/icons/filebeat_chart';
import { checkArtifactHasData } from './services/exceptions_list/check_artifact_has_data';
import {
calculateEndpointAuthz,
Expand Down Expand Up @@ -231,7 +230,7 @@ export const links: LinkItem = {
defaultMessage:
'Oversee, revise and revisit the annotations within each document and timeline.',
}),
landingIcon: IconFilebeatChart,
landingIcon: 'filebeatApp',
path: NOTES_PATH,
skipUrlState: true,
hideTimeline: true,
Expand Down