Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Cleanup services #194634

Merged
merged 45 commits into from
Oct 8, 2024
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
85de1cc
Starting work on refactor
Heenawter Sep 26, 2024
9f10903
Remove platform service
Heenawter Sep 26, 2024
20270be
Refactor notify + expressions services
Heenawter Oct 1, 2024
bc18acd
Start cleaning up hooks
Heenawter Oct 1, 2024
bc02982
Refactor reporting service
Heenawter Oct 1, 2024
d0681b0
Refactor custom elements service
Heenawter Oct 1, 2024
d10cb91
Remove last of plugin services
Heenawter Oct 1, 2024
49c8a61
Fix data views service hook
Heenawter Oct 1, 2024
d0d28c2
Make workpad service a class
Heenawter Oct 1, 2024
258fc97
Fix workpad service
Heenawter Oct 2, 2024
c5ada39
Trying to fix storybooks
Heenawter Oct 2, 2024
4a9d90f
Move hooks
Heenawter Oct 2, 2024
f8253aa
Fix hooks
Heenawter Oct 2, 2024
e93c62a
Move things out of `hooks` and fix (?) public export
Heenawter Oct 2, 2024
419afbd
Remove unnecessary hooks
Heenawter Oct 3, 2024
8d8ab83
Update `tsconfig`
Heenawter Oct 3, 2024
2d33d99
Fix bundle size
Heenawter Oct 3, 2024
81a28ae
Re-add `useNotifyService`
Heenawter Oct 3, 2024
aa88d85
Remove data views service
Heenawter Oct 3, 2024
8ebd8ce
Fix mock services
Heenawter Oct 3, 2024
435d5c2
Add filters actions
cqliu1 Oct 3, 2024
e451ebb
Fix circular deps
cqliu1 Oct 3, 2024
0988e32
Cleanup + fix undefined expression service
Heenawter Oct 3, 2024
6bccb22
Add fetch all renderables
Heenawter Oct 3, 2024
ad5231d
Clean up commented out imports
Heenawter Oct 3, 2024
94132c4
Merge pull request #11 from cqliu1/fix/canvas-circ-dep
Heenawter Oct 3, 2024
ce06331
Remove unused imports
Heenawter Oct 3, 2024
0b7dade
Fix linting
Heenawter Oct 3, 2024
5be8aca
Merge branch 'main' into cleanup-canvas-services_2024-09-26
Heenawter Oct 4, 2024
6acbf92
Fix unit tests
Heenawter Oct 4, 2024
fe41745
Fix custom element service
Heenawter Oct 4, 2024
4aede23
Fix embeddable update
Heenawter Oct 4, 2024
e1c74da
Fix linting
Heenawter Oct 4, 2024
60b695e
Clean up?
Heenawter Oct 4, 2024
3522192
Try to fix linting error
Heenawter Oct 7, 2024
bb45fd5
Merge branch 'main' into cleanup-canvas-services_2024-09-26
Heenawter Oct 7, 2024
9ccfb0c
Fix reporting service
Heenawter Oct 7, 2024
452bd89
Fix undefined reporting
Heenawter Oct 7, 2024
f6d892d
Small cleanups
Heenawter Oct 7, 2024
10849ac
Merge branch 'main' into cleanup-canvas-services_2024-09-26
Heenawter Oct 8, 2024
7b2eae7
Fix merge conflicts
Heenawter Oct 8, 2024
71b386d
Remove space from HTML
Heenawter Oct 8, 2024
ee5edad
Remove `core` from presentation util
Heenawter Oct 8, 2024
78ee22b
Review feedback
Heenawter Oct 8, 2024
ad95d9c
Remove unused import
Heenawter Oct 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix mock services
  • Loading branch information
Heenawter committed Oct 3, 2024
commit 8ebd8cea7d20bfa936a277d9946a166ecc5c98ec
1 change: 0 additions & 1 deletion x-pack/plugins/canvas/public/services/mocks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ export const setStubKibanaServices = () => {
uiActions: uiActionsPluginMock.createStartContract(),
visualizations: visualizationsPluginMock.createStartContract(),
},
new BehaviorSubject<AppUpdater>(() => ({})),
coreMock.createPluginInitializerContext()
);
};
Expand Down