Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide progress bar on initial load when client prefers reduced motion #194365

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Hide progress bar on initial load when client prefers reduced motion #194365

merged 3 commits into from
Sep 30, 2024

Conversation

smith
Copy link
Contributor

@smith smith commented Sep 30, 2024 •
edited by kibanamachine
Loading

@smith smith requested a review from a team as a code owner September 30, 2024 02:54
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@smith smith added backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development release_note:skip Skip the PR/issue when compiling release notes labels Sep 30, 2024
jloleysens
jloleysens approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'd be curious to hear what the EUI team suggests for handling this media query. Perhaps it's something we can set/control via some global React context?

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #14 / Create renders correctly with optional fields

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 2a935dc into elastic:main Sep 30, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.x

https://github.com/elastic/kibana/actions/runs/11108713623

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.15 Could not create pull request: You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID E4C0:145A9:15644CB:29D28F2:66FABD12 and timestamp 2024-09-30 15:00:34 UTC.
❌ 8.x Could not create pull request: You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID E4C0:145A9:15675FE:29D882C:66FABD1F and timestamp 2024-09-30 15:00:47 UTC.

Manual backport

To create the backport manually run:

node scripts/backport --pr 194365

Questions ?

Please refer to the Backport tool documentation

@smith smith removed the backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development label Sep 30, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 30, 2024
@smith smith added backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development and removed backport:skip This commit does not require backporting labels Sep 30, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.x

https://github.com/elastic/kibana/actions/runs/11115074902

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.x

https://github.com/elastic/kibana/actions/runs/11115074903

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 30, 2024
@smith
Hide progress bar on initial load when client prefers reduced motion (e…
56513e4 
…lastic#194365)

## Summary

See
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion

![CleanShot 2024-09-29 at 21 57
36](https://github.com/user-attachments/assets/27436ec4-986b-4c91-9d9f-e49d59d76e7c)

(cherry picked from commit 2a935dc)
@kibanamachine kibanamachine mentioned this pull request Sep 30, 2024
Merged
@kibanamachine kibanamachine mentioned this pull request Sep 30, 2024
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.15 An unhandled error occurred. Please see the logs for details
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 194365

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 30, 2024
@smith
Hide progress bar on initial load when client prefers reduced motion (e…
f02af64 
…lastic#194365)

## Summary

See
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion

![CleanShot 2024-09-29 at 21 57
36](https://github.com/user-attachments/assets/27436ec4-986b-4c91-9d9f-e49d59d76e7c)

(cherry picked from commit 2a935dc)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Sep 30, 2024
Merged
13 tasks
kibanamachine added a commit that referenced this pull request Sep 30, 2024
@kibanamachine @smith
[8.15] Hide progress bar on initial load when client prefers reduced …
4f84ab0 
…motion (#194365) (#194495)

# Backport

This will backport the following commits from `main` to `8.15`:
- [Hide progress bar on initial load when client prefers reduced motion
(#194365)](#194365)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan L
Smith","email":"nathan.smith@elastic.co"},"sourceCommit":{"committedDate":"2024-09-30T14:55:49Z","message":"Hide
progress bar on initial load when client prefers reduced motion
(#194365)\n\n##
Summary\r\n\r\nSee\r\nhttps://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion\r\n\r\n![CleanShot
2024-09-29 at 21
57\r\n36](https://github.com/user-attachments/assets/27436ec4-986b-4c91-9d9f-e49d59d76e7c)","sha":"2a935dcce37bd3e3f3fce32d6257b2ec7191dac5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major"],"title":"Hide
progress bar on initial load when client prefers reduced
motion","number":194365,"url":"https://github.com/elastic/kibana/pull/194365","mergeCommit":{"message":"Hide
progress bar on initial load when client prefers reduced motion
(#194365)\n\n##
Summary\r\n\r\nSee\r\nhttps://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion\r\n\r\n![CleanShot
2024-09-29 at 21
57\r\n36](https://github.com/user-attachments/assets/27436ec4-986b-4c91-9d9f-e49d59d76e7c)","sha":"2a935dcce37bd3e3f3fce32d6257b2ec7191dac5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194365","number":194365,"mergeCommit":{"message":"Hide
progress bar on initial load when client prefers reduced motion
(#194365)\n\n##
Summary\r\n\r\nSee\r\nhttps://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion\r\n\r\n![CleanShot
2024-09-29 at 21
57\r\n36](https://github.com/user-attachments/assets/27436ec4-986b-4c91-9d9f-e49d59d76e7c)","sha":"2a935dcce37bd3e3f3fce32d6257b2ec7191dac5"}}]}]
BACKPORT-->

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
kibanamachine added a commit that referenced this pull request Sep 30, 2024
@kibanamachine @smith
[8.x] Hide progress bar on initial load when client prefers reduced m…
e99ab27 
…otion (#194365) (#194496)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Hide progress bar on initial load when client prefers reduced motion
(#194365)](#194365)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan L
Smith","email":"nathan.smith@elastic.co"},"sourceCommit":{"committedDate":"2024-09-30T14:55:49Z","message":"Hide
progress bar on initial load when client prefers reduced motion
(#194365)\n\n##
Summary\r\n\r\nSee\r\nhttps://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion\r\n\r\n![CleanShot
2024-09-29 at 21
57\r\n36](https://github.com/user-attachments/assets/27436ec4-986b-4c91-9d9f-e49d59d76e7c)","sha":"2a935dcce37bd3e3f3fce32d6257b2ec7191dac5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major"],"title":"Hide
progress bar on initial load when client prefers reduced
motion","number":194365,"url":"https://github.com/elastic/kibana/pull/194365","mergeCommit":{"message":"Hide
progress bar on initial load when client prefers reduced motion
(#194365)\n\n##
Summary\r\n\r\nSee\r\nhttps://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion\r\n\r\n![CleanShot
2024-09-29 at 21
57\r\n36](https://github.com/user-attachments/assets/27436ec4-986b-4c91-9d9f-e49d59d76e7c)","sha":"2a935dcce37bd3e3f3fce32d6257b2ec7191dac5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194365","number":194365,"mergeCommit":{"message":"Hide
progress bar on initial load when client prefers reduced motion
(#194365)\n\n##
Summary\r\n\r\nSee\r\nhttps://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion\r\n\r\n![CleanShot
2024-09-29 at 21
57\r\n36](https://github.com/user-attachments/assets/27436ec4-986b-4c91-9d9f-e49d59d76e7c)","sha":"2a935dcce37bd3e3f3fce32d6257b2ec7191dac5"}}]}]
BACKPORT-->

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development release_note:skip Skip the PR/issue when compiling release notes v8.15.3 v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smith @obltmachine @kibana-ci @kibanamachine @jloleysens