[Stateful sidenav] Hide out solutions result in global search #194279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
163a0e4 to
e37f6f4
Compare
|
/ci |
1 similar comment
|
/ci |
bc0a547 to
352dcba
Compare
|
/ci |
672d965 to
352dcba
Compare
|
/ci |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
daveyholler
approved these changes
Oct 2, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @sebelga |
SiddharthMantri
approved these changes
Oct 4, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11178734170 |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 4, 2024
…194279) (#194928) # Backport This will backport the following commits from `main` to `8.x`: - [[Stateful sidenav] Hide out solutions result in global search (#194279)](#194279) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"sebastien.loix@elastic.co"},"sourceCommit":{"committedDate":"2024-10-04T10:59:46Z","message":"[Stateful sidenav] Hide out solutions result in global search (#194279)","sha":"3ea6b1327737f0fcf00ac31b43295f8737526500","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","ci:project-deploy-observability","apm:review"],"title":"[Stateful sidenav] Hide out solutions result in global search","number":194279,"url":"https://github.com/elastic/kibana/pull/194279","mergeCommit":{"message":"[Stateful sidenav] Hide out solutions result in global search (#194279)","sha":"3ea6b1327737f0fcf00ac31b43295f8737526500"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194279","number":194279,"mergeCommit":{"message":"[Stateful sidenav] Hide out solutions result in global search (#194279)","sha":"3ea6b1327737f0fcf00ac31b43295f8737526500"}}]}] BACKPORT--> Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've fixed global search results from appearing when solutions are disabled.
With the new
space.solution, we automatically disable solution apps that don't belong to the selected solution. We notice that, in some cases, even when the app is disabled, search results where still showing up. See linked issue for details.Fixes https://github.com/elastic/kibana-team/issues/1136
Note: The fixes for security were done in #191965
Changes in Security spaces
As discussed with @legrego I updated the spaces client to dynamically set the
disabledFeaturesarray based on thespace.solution. This is a follow up work of #191927 (see comment).This was needed in order to handle places in Kibana (like here) that depend on the
disabledFeaturesarray. And in this concrete case it was needed for this PR to fix the global search issue.