[ES|QL] Renames the textbased editor to esql editor #193521

stratoula · 2024-09-20T09:04:57Z

Summary

Renames the text-based-editor to esql-editor

I tried to also rename components, data-test-subj, classNames and files. My focus is mostly on the plugin and package of the esql editor

…ocs'

elasticmachine · 2024-09-20T13:09:10Z

Pinging @elastic/kibana-esql (Team:ESQL)

walterra

ML related changes LGTM.

jughosta

Data Discovery changes LGTM 👍

jbudz

.buildkite/scripts/steps/storybooks/build_and_upload.ts, src/dev/storybook/aliases.ts

nreese

kibana-presentation changes LGTM
code review only

nreese · 2024-09-20T14:15:14Z

test/functional/apps/dashboard/group6/dashboard_esql_chart.ts

@@ -64,7 +64,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
      await dashboard.waitForRenderComplete();

      await monacoEditor.setCodeEditorValue('from logstash-* | stats maxB = max(bytes)');
-      await testSubjects.click('TextBasedLangEditor-run-query-button');
+      await testSubjects.click('ESQLEditor-run-query-button');


Would it make sense to move this to a page object or service?

It would but not on this PR.

dominiqueclarke

Obs ux management changes LGTM

stratoula · 2024-09-23T08:16:17Z

/ci

kibana-ci · 2024-09-23T09:16:32Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 3b0f859
Storybooks Preview
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193521-3b0f859d0394

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/esql-editor`	-	12	+12
`@kbn/text-based-editor`	12	-	-12
total			-0

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dataVisualizer`	726.5KB	726.5KB	-10.0B
`esql`	172.9KB	171.4KB	-1.5KB
`investigateApp`	465.1KB	465.0KB	-5.0B
`lens`	1.5MB	1.5MB	-14.0B
`maps`	3.0MB	3.0MB	-5.0B
`stackAlerts`	75.7KB	75.7KB	-5.0B
`unifiedSearch`	341.6KB	341.6KB	-5.0B
total			-1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`esql`	6.5KB	6.5KB	-5.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/esql-editor`	-	29	+29
`@kbn/text-based-editor`	29	-	-29
total			-0

ESLint disabled line counts

id	before	after	diff
`@kbn/esql-editor`	-	5	+5
`@kbn/text-based-editor`	5	-	-5
total			-0

Total ESLint disabled count

id	before	after	diff
`@kbn/esql-editor`	-	5	+5
`@kbn/text-based-editor`	5	-	-5
total			-0

History

💛 Build #236232 was flaky 3b0f859
💔 Build #236200 failed c3644d5
💔 Build #236199 failed c3644d5
💚 Build #235905 succeeded 5620c67
💔 Build #235893 failed 0c55db4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2024-09-23T10:11:37Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts You might need to backport the following PRs to 8.x: - [[ES

Manual backport

To create the backport manually run:

node scripts/backport --pr 193521

Questions ?

Please refer to the Backport tool documentation

## Summary Renames the text-based-editor to esql-editor I tried to also rename components, data-test-subj, classNames and files. My focus is mostly on the plugin and package of the esql editor --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d56a1bb) # Conflicts: # .github/CODEOWNERS

stratoula · 2024-09-23T11:50:35Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…193706) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Renames the textbased editor to esql editor (#193521)](#193521)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)

* main: (176 commits) [ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (elastic#193420) Bump maximum supported package spec version to 3.2 (elastic#193574) [ES|QL] new pattern for `SORT` autocomplete (elastic#193595) [Inventory][ECO] Entities page search bar (elastic#193546) [Synthetics] Remove extra overview route (elastic#192449) [Obs Alerts table] Fix error on clicking alert reason message (elastic#193693) [Migrations] Remove tests that are not applicable in 9.x (elastic#193699) [EDR Workflows] Set Agent Tamper Protection to false on policy unassignment (elastic#193017) [Inventory][ECO] Enable elastic entity model from inventory (elastic#193557) [EDR Workflows] The host isolation exception tab is hidden on the basic license if no artifacts (elastic#192562) [Entity Analytics] Ensuring definition transforms are managed (elastic#193408) [Automatic Import] Do not remove message field for unstructured logs (elastic#193678) [Fleet] Add missing permissions for connector package (elastic#193573) [Fleet] using @kbn/config-schema part 2 (outputs and other apis) (elastic#193326) [Migrations] Provide testing archives + tooling for migrations integration tests (elastic#193328) [ES|QL] Renames the textbased editor to esql editor (elastic#193521) [ES|QL] Update function metadata (elastic#193662) [Security Solution][Entity Analytics] Scoping the entity store to spaces (elastic#193303) [Docs] Update Sharing docs (elastic#190318) [ML] AIOps: Move Log Rate Analysis results callout to help popover. (elastic#192243) ... # Conflicts: # x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.test.tsx # x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx

stratoula added 3 commits September 20, 2024 11:04

Renames the textbased editor to esql editor

e1c357c

Rename mock file

70c4e8a

Further cleanup

975b6b8

stratoula changed the title ~~Renames the textbased editor to esql editor~~ [ES|QL] Renames the textbased editor to esql editor Sep 20, 2024

kibanamachine and others added 4 commits September 20, 2024 09:27

[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…

6357966

…ocs'

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

f8dc028

fix ci check

0c55db4

Fix

5620c67

stratoula marked this pull request as ready for review September 20, 2024 13:09

stratoula requested review from a team as code owners September 20, 2024 13:09

stratoula requested a review from a team as a code owner September 20, 2024 13:09

walterra approved these changes Sep 20, 2024

View reviewed changes

botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 20, 2024

jughosta approved these changes Sep 20, 2024

View reviewed changes

jbudz approved these changes Sep 20, 2024

View reviewed changes

nreese approved these changes Sep 20, 2024

View reviewed changes

nickofthyme approved these changes Sep 20, 2024

View reviewed changes

dominiqueclarke approved these changes Sep 20, 2024

View reviewed changes

ryankeairns approved these changes Sep 20, 2024

View reviewed changes

drewdaemon approved these changes Sep 20, 2024

View reviewed changes

cnasikas approved these changes Sep 21, 2024

View reviewed changes

stratoula added 2 commits September 23, 2024 08:22

Merge with main and resolve conflicts

c3644d5

Merge with main and resolve conflcts

3b0f859

stratoula merged commit d56a1bb into elastic:main Sep 23, 2024
62 checks passed

stratoula mentioned this pull request Sep 23, 2024

[8.x] [ES|QL] Renames the textbased editor to esql editor (#193521) #193706

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ES|QL] Renames the textbased editor to esql editor #193521

[ES|QL] Renames the textbased editor to esql editor #193521

stratoula commented Sep 20, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Sep 20, 2024

walterra left a comment

jughosta left a comment

jbudz left a comment

nreese left a comment

nreese Sep 20, 2024

stratoula Sep 20, 2024

dominiqueclarke left a comment

stratoula commented Sep 23, 2024

kibana-ci commented Sep 23, 2024 •

edited

Loading

API count

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented Sep 23, 2024

stratoula commented Sep 23, 2024

[ES|QL] Renames the textbased editor to esql editor #193521

[ES|QL] Renames the textbased editor to esql editor #193521

Conversation

stratoula commented Sep 20, 2024 • edited by kibanamachine Loading

Summary

elasticmachine commented Sep 20, 2024

walterra left a comment

Choose a reason for hiding this comment

jughosta left a comment

Choose a reason for hiding this comment

jbudz left a comment

Choose a reason for hiding this comment

nreese left a comment

Choose a reason for hiding this comment

nreese Sep 20, 2024

Choose a reason for hiding this comment

stratoula Sep 20, 2024

Choose a reason for hiding this comment

dominiqueclarke left a comment

Choose a reason for hiding this comment

stratoula commented Sep 23, 2024

kibana-ci commented Sep 23, 2024 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented Sep 23, 2024

💔 All backports failed

Manual backport

Questions ?

stratoula commented Sep 23, 2024

💚 All backports created successfully

Questions ?

stratoula commented Sep 20, 2024 •

edited by kibanamachine

Loading

kibana-ci commented Sep 23, 2024 •

edited

Loading