[ResponseOps][Cases] Fix a bug with cases telemetry where data from other spaces are not included #193166

cnasikas · 2024-09-17T13:13:36Z

Summary

The Find SO API supports the namespaces parameter where you can define the spaces that the SO client should search for. If you omit the namespaces parameter, the SO client will use the active space. This PR creates a wrapper around the SO client to add the namespaces: ['*'] to all Find SO usages to count telemetry on all spaces.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2024-09-17T14:28:56Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2024-09-17T14:28:57Z

Pinging @elastic/response-ops-cases (Feature:Cases)

adcoelho · 2024-09-17T14:51:05Z

x-pack/plugins/cases/server/telemetry/queries/case_system_action.ts

@@ -26,6 +26,7 @@ export const getCasesSystemActionData = async ({
        cardinality: { field: `${CASE_RULES_SAVED_OBJECT}.attributes.rules.id` },
      },
    },
+    namespaces: ['*'],


nit: maybe we could also update case_system_action.test.ts to have expect(savedObjectsClient.find...).toHaveBeenCalledWith or something like that. I see the other tests do that.

Good point! Done!

adcoelho · 2024-09-17T14:52:23Z

x-pack/plugins/cases/server/telemetry/queries/pushed.test.ts

@@ -86,6 +86,7 @@ describe('pushes', () => {
        page: 0,
        perPage: 0,
        type: 'cases-user-actions',
+        namespaces: ['*'],


Why is this test file called pushed.test.ts 😄 I think it's a typo.

lol I think it should be push you are right. I will change it.

js-jankisalvi

TIL! Never thought about other spaces data 👍

…fix'

…kibana into cases_fix_telemetry_namespaces

kibana-ci · 2024-09-18T19:14:22Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 07d16a0

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #19 / console app Console variables with variables in request body should send a successful request

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`@kbn/test-suites-xpack`	720	721	+1

Total ESLint disabled count

id	before	after	diff
`@kbn/test-suites-xpack`	744	745	+1

History

💔 Build #235164 failed 03e48fd
💚 Build #234880 succeeded 1032d86

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

kibanamachine · 2024-09-19T12:11:14Z

💔 All backports failed

Status	Branch	Result
❌	8.15	Backport failed because of merge conflicts
❌	8.x	Backport failed because of merge conflicts You might need to backport the following PRs to 8.x: - Added scope field to features config. (#191634)

Manual backport

To create the backport manually run:

node scripts/backport --pr 193166

Questions ?

Please refer to the Backport tool documentation

…ther spaces are not included (elastic#193166) ## Summary The Find SO API supports the `namespaces` parameter where you can define the spaces that the SO client should search for. If you omit the `namespaces` parameter, the SO client will use the active space. This PR creates a wrapper around the SO client to add the `namespaces: ['*']` to all Find SO usages to count telemetry on all spaces. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 6b372b7) # Conflicts: # x-pack/test/cases_api_integration/common/plugins/cases/server/plugin.ts

cnasikas · 2024-09-19T12:34:38Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x
✅	8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ther spaces are not included (elastic#193166) ## Summary The Find SO API supports the `namespaces` parameter where you can define the spaces that the SO client should search for. If you omit the `namespaces` parameter, the SO client will use the active space. This PR creates a wrapper around the SO client to add the `namespaces: ['*']` to all Find SO usages to count telemetry on all spaces. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 6b372b7) # Conflicts: # x-pack/test/cases_api_integration/common/plugins/cases/server/plugin.ts # x-pack/test/cases_api_integration/common/plugins/cases/tsconfig.json

jcger · 2024-09-19T13:18:26Z

x-pack/test/cases_api_integration/common/plugins/cases/server/routes.ts

@@ -178,4 +179,32 @@ export const registerRoutes = (core: CoreSetup<FixtureStartDeps>, logger: Logger
      }
    }
  );
+
+  router.post(


do we need to add this new route to the http versioning tasks? I see no versioning here

Hey! This is a fake route on a fake plugin that is registered only for testing.

…from other spaces are not included (#193166) (#193417) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Cases] Fix a bug with cases telemetry where data from other spaces are not included (#193166)](#193166)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)

… from other spaces are not included (#193166) (#193418) # Backport This will backport the following commits from `main` to `8.15`: - [[ResponseOps][Cases] Fix a bug with cases telemetry where data from other spaces are not included (#193166)](#193166)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.16.0 v8.15.2 labels Sep 17, 2024

cnasikas self-assigned this Sep 17, 2024

Add namespace to SO clients

1032d86

cnasikas force-pushed the cases_fix_telemetry_namespaces branch from 305d4b5 to 1032d86 Compare September 17, 2024 14:25

cnasikas added the bug Fixes for quality problems that affect the customer experience label Sep 17, 2024

cnasikas marked this pull request as ready for review September 17, 2024 14:28

cnasikas requested a review from a team as a code owner September 17, 2024 14:28

cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label Sep 17, 2024

guskovaue approved these changes Sep 17, 2024

View reviewed changes

adcoelho reviewed Sep 17, 2024

View reviewed changes

adcoelho approved these changes Sep 17, 2024

View reviewed changes

js-jankisalvi approved these changes Sep 18, 2024

View reviewed changes

cnasikas and others added 6 commits September 18, 2024 13:41

Use the TelemetrySavedObjectsClient class instead of the SO client

915cb88

Add telemetry integration test

6b230f1

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

03e48fd

…fix'

Merge branch 'main' into cases_fix_telemetry_namespaces

acbf9bc

Fix types

e628392

Merge branch 'cases_fix_telemetry_namespaces' of github.com:cnasikas/…

07d16a0

…kibana into cases_fix_telemetry_namespaces

cnasikas added the v9.0.0 label Sep 19, 2024

cnasikas merged commit 6b372b7 into elastic:main Sep 19, 2024
30 of 31 checks passed

cnasikas deleted the cases_fix_telemetry_namespaces branch September 19, 2024 12:06

cnasikas mentioned this pull request Sep 19, 2024

[8.x] [ResponseOps][Cases] Fix a bug with cases telemetry where data from other spaces are not included (#193166) #193417

Merged

cnasikas mentioned this pull request Sep 19, 2024

[8.15] [ResponseOps][Cases] Fix a bug with cases telemetry where data from other spaces are not included (#193166) #193418

Merged

kibanamachine mentioned this pull request Sep 19, 2024

[fix] regenerate and add missing openapi-generated files #193419

Merged

jcger reviewed Sep 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ResponseOps][Cases] Fix a bug with cases telemetry where data from other spaces are not included #193166

[ResponseOps][Cases] Fix a bug with cases telemetry where data from other spaces are not included #193166

cnasikas commented Sep 17, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Sep 17, 2024

elasticmachine commented Sep 17, 2024

adcoelho Sep 17, 2024

cnasikas Sep 18, 2024 •

edited

Loading

adcoelho Sep 17, 2024 •

edited

Loading

cnasikas Sep 18, 2024

js-jankisalvi left a comment

kibana-ci commented Sep 18, 2024

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented Sep 19, 2024

cnasikas commented Sep 19, 2024

jcger Sep 19, 2024

cnasikas Sep 19, 2024

jcger Sep 19, 2024

[ResponseOps][Cases] Fix a bug with cases telemetry where data from other spaces are not included #193166

[ResponseOps][Cases] Fix a bug with cases telemetry where data from other spaces are not included #193166

Conversation

cnasikas commented Sep 17, 2024 • edited by kibanamachine Loading

Summary

Checklist

For maintainers

elasticmachine commented Sep 17, 2024

elasticmachine commented Sep 17, 2024

adcoelho Sep 17, 2024

Choose a reason for hiding this comment

cnasikas Sep 18, 2024 • edited Loading

Choose a reason for hiding this comment

adcoelho Sep 17, 2024 • edited Loading

Choose a reason for hiding this comment

cnasikas Sep 18, 2024

Choose a reason for hiding this comment

js-jankisalvi left a comment

Choose a reason for hiding this comment

kibana-ci commented Sep 18, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented Sep 19, 2024

💔 All backports failed

Manual backport

Questions ?

cnasikas commented Sep 19, 2024

💚 All backports created successfully

Questions ?

jcger Sep 19, 2024

Choose a reason for hiding this comment

cnasikas Sep 19, 2024

Choose a reason for hiding this comment

jcger Sep 19, 2024

Choose a reason for hiding this comment

cnasikas commented Sep 17, 2024 •

edited by kibanamachine

Loading

cnasikas Sep 18, 2024 •

edited

Loading

adcoelho Sep 17, 2024 •

edited

Loading