-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS|Dashboard] Updated images and text to match UI #19149
Conversation
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice. Much cleaner.
docs/dashboard.asciidoc
Outdated
@@ -3,163 +3,109 @@ | |||
|
|||
[partintro] | |||
-- | |||
A Kibana _dashboard_ displays a collection of saved visualizations. | |||
A Kibana _dashboard_ displays a collection of visualizations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to mention saved searches
. "A kibana dashboard displays a collection of visualizations and searches".
docs/dashboard.asciidoc
Outdated
[float] | ||
[[moving-containers]] | ||
==== Moving Visualizations | ||
The visualizations in your dashboard are stored in containers that you can move, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to use a more generic term since dashboards can hold more than just visualizations. Maybe panels
? Same commit for all uses of visualization
in this file.
docs/dashboard.asciidoc
Outdated
(CSV) file, click the *Raw* or *Formatted* link at the bottom of the data | ||
Table. *Raw* exports the data as it is stored in Elasticsearch. *Formatted* | ||
exports the results of any applicable Kibana <<managing-fields,field | ||
To export the data as a comma separated values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is very misleading - you are not exporting the raw documents as stored in elasticsearch, you are only exporting the raw aggregation results as returned from the API call. Maybe something like
"To export the response data as a comma separated values (CSV) file, click Raw or Formatted at the bottom of the data table. Raw exports the response data as provided. Formatted exports the response data using applicable Kibana field formatters."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. I thought it was pretty clear that by "raw data", she meant the data that was fed into the aggregation, not the original docs themselves, e.g. the aggregation data. Maybe, instead of "raw data", it should say something like:
"To export the visualization data" or "To export the aggregated data displayed in a visualization..." Dunnoes. Writing is hard.
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is great!
docs/dashboard.asciidoc
Outdated
(CSV) file, click the *Raw* or *Formatted* link at the bottom of the data | ||
Table. *Raw* exports the data as it is stored in Elasticsearch. *Formatted* | ||
exports the results of any applicable Kibana <<managing-fields,field | ||
To export the data as a comma separated values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. I thought it was pretty clear that by "raw data", she meant the data that was fed into the aggregation, not the original docs themselves, e.g. the aggregation data. Maybe, instead of "raw data", it should say something like:
"To export the visualization data" or "To export the aggregated data displayed in a visualization..." Dunnoes. Writing is hard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left some feedback that you can take or leave. There will be some things changing in 6.4 that will leave some of these screenshots out of date (add panel is one), but it's hard to keep up with all the changes, so this is a very good improvement!
The request statistics show the query duration, request duration, total number | ||
of matching records, and the index (or index pattern) that was searched. | ||
. Open the dashboard. | ||
. Hover over the visualization and click the *Expand* button in the lower |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be changing for 6.4 so that this functionality is exposed in the gear menu. Fine to leave it like this for now, but I want to point out that not all visualizations support it. Right now, in 6.3, no time series visual builder visualizations show it. Maybe not vega/timelion... I'd have to check. Not a huge deal, but might want to add a caveat like "If supported ...."
A lot of stuff will be going that route. When we have "Create Machine Learning Job" it'll only be for certain embeddables. I don't have a good generic term for embeddables. Right now it's only saved searches and visualizations, but it could eventually be more. In addition, even for one embeddable type (like our visualizations), panel options can change based on the visualization sub type.
I'm not opposed to just calling them visualizations because I think that is a nice generic term in itself, but it's overloaded because right now when we say visualizations we mean a specific embeddable type. 🤷♀️
docs/dashboard.asciidoc
Outdated
share the live dashboard or a static snapshot of the current point in time. | ||
. In the menu bar, click *Share*. | ||
. Copy the link you want to share or the iframe you want to embed. You can | ||
share the live dashboard or a static snapshot of the current point in time. | ||
+ | ||
TIP: When sharing a link to a dashboard snapshot, use the *Short URL*. Snapshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A common thing that trips people up is that users must have write access to .kibana to create short urls. May be worth calling out.
Another thing that might be worth calling out that isn't exposed in the UI at all but many people find handy is that you can create a link to a dashboard by title, by doing this:
${domain}/${basepath?}/app/kibana#/dashboards?title=${yourdashboardtitle}
It's not exposed in the UI because we can't figure out how to communicate it properly (maybe you will have some ideas!). Because it's just linked by title and not id, changing titles on dashboards can change the link. So you can't really say "link to this dashboard" because that might not be true later down the road. Here is the PR it was implemented : #14760
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* [DOCS|Dashboard] Updated images and text to match UI * [DOCS | Dashboard] Incorporated review comments * [DOCS | DASHBOARD] Incorporated more review comments.
* [DOCS|Dashboard] Updated images and text to match UI * [DOCS | Dashboard] Incorporated review comments * [DOCS | DASHBOARD] Incorporated more review comments.
* [DOCS|Dashboard] Updated images and text to match UI * [DOCS | Dashboard] Incorporated review comments * [DOCS | DASHBOARD] Incorporated more review comments.
* [DOCS|Dashboard] Updated images and text to match UI * [DOCS | Dashboard] Incorporated review comments * [DOCS | DASHBOARD] Incorporated more review comments.
The PR updates the Dashboard document. Images and text were revised to reflect what's in 6.x.
The updated docs are staged here for review:
https://my-kibana-docs.firebaseapp.com/html_docs/dashboard.html
@elastic/kibana-sharing