Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] fix cloud formation pop-up flicker #191136

Merged
merged 2 commits into from
Aug 23, 2024
Merged

[Cloud Security] fix cloud formation pop-up flicker #191136

merged 2 commits into from
Aug 23, 2024

Conversation

Omolola-Akinleye
Copy link
Contributor

@Omolola-Akinleye Omolola-Akinleye commented Aug 22, 2024 •
edited
Loading

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

If go to CSPM page and click save and continue, the Cloud Formation Pop occasionally flickers and shows Fleet Server host error for one second. This PR adds a boolean isLoadingIntialRequest for us to wait after loading Fleet Server hosts before showing the errors.

Quick Wins

Locally:
https://github.com/user-attachments/assets/bf393103-9d21-4ddf-96a9-8fc3e9626369

Serverless QA

Screen.Recording.2024-08-23.at.11.19.28.AM.mov

@Omolola-Akinleye Omolola-Akinleye added release_note:skip Skip the PR/issue when compiling release notes ci:project-deploy-security Create a Security Serverless Project Team: Cloud Security labels Aug 22, 2024
@Omolola-Akinleye Omolola-Akinleye marked this pull request as ready for review August 22, 2024 20:38
@Omolola-Akinleye Omolola-Akinleye requested review from a team as code owners August 22, 2024 20:38
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@opauloh opauloh added Team:Cloud Security Cloud Security team related and removed Team: Cloud Security labels Aug 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 22, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #79 / Cloud Security Posture Test adding Cloud Security Posture Integrations CSPM GCP CIS_GCP Organization Post Installation Google Cloud Shell modal pops up after user clicks on Save button when adding integration, when there are Project ID or Organization ID provided, it should use that value

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB +30.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

opauloh
opauloh approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jillguyonnet
jillguyonnet approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@jillguyonnet jillguyonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet 👍 🚀

@Omolola-Akinleye Omolola-Akinleye merged commit 5d0acf7 into elastic:main Aug 23, 2024
27 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opauloh opauloh opauloh approved these changes

@jillguyonnet jillguyonnet jillguyonnet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-security Create a Security Serverless Project release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Omolola-Akinleye @elasticmachine @kibana-ci @opauloh @jillguyonnet @kibanamachine