-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] Provide troubleshooting information on the host details page #191104
Merged
jennypavlova
merged 14 commits into
elastic:main
from
jennypavlova:190523-infra-provide-troubleshooting-information-on-the-host-details-page
Aug 23, 2024
Merged
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b533b77
Add troubleshooting link to apm services empty message
jennypavlova 7613e09
Add troubleshooting message and link for hosts with/without system me…
jennypavlova 611d6b3
Merge branch 'main' into 190523-infra-provide-troubleshooting-informa…
jennypavlova cdfb4f6
Extract the documentation link to a constant
jennypavlova f37b2c1
Fix the test type
jennypavlova a56bc7f
Add missing title popover
jennypavlova e7b829e
Add hasSystemIntegration only for hosts
jennypavlova 5ae2fa6
Merge branch 'main' into 190523-infra-provide-troubleshooting-informa…
jennypavlova 30ee7a1
Merge branch 'main' into 190523-infra-provide-troubleshooting-informa…
jennypavlova 429f136
CR changes
jennypavlova ab69314
Fix unit test
jennypavlova bac9b25
Merge branch 'main' into 190523-infra-provide-troubleshooting-informa…
jennypavlova 5a7ac87
Add check in the integration test
jennypavlova ad40529
Merge branch '190523-infra-provide-troubleshooting-information-on-the…
jennypavlova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
...ability_solution/infra/public/components/asset_details/header/page_title_with_popover.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
import React from 'react'; | ||
|
||
import { EuiText, EuiLink, EuiFlexGroup, EuiFlexItem } from '@elastic/eui'; | ||
import { FormattedMessage } from '@kbn/i18n-react'; | ||
import { APM_HOST_TROUBLESHOOTING_LINK } from '../constants'; | ||
import { Popover } from '../tabs/common/popover'; | ||
|
||
export const PageTitleWithPopover = ({ | ||
hasSystemMetrics, | ||
name, | ||
}: { | ||
hasSystemMetrics: boolean; | ||
name: string; | ||
}) => { | ||
return !hasSystemMetrics ? ( | ||
<EuiFlexGroup gutterSize="xs" alignItems="center" responsive={false}> | ||
<EuiFlexItem grow={false}>{name}</EuiFlexItem> | ||
<EuiFlexItem grow={false}> | ||
<Popover icon="questionInCircle" data-test-subj="assetDetailsTitleHasSystemMetricsPopover"> | ||
<EuiText size="xs"> | ||
<p> | ||
<FormattedMessage | ||
id="xpack.infra.assetDetails.title.tooltip.apmHostMessage" | ||
defaultMessage="This host has been detected by {apm}" | ||
values={{ | ||
apm: ( | ||
<EuiLink | ||
data-test-subj="assetDetailsTitleTooltipApmDocumentationLink" | ||
href=" https://www.elastic.co/guide/en/observability/current/apm.html" | ||
target="_blank" | ||
> | ||
<FormattedMessage | ||
id="xpack.infra.assetDetails.title.tooltip.apmHostMessage.apmDocumentationLink" | ||
defaultMessage="APM" | ||
/> | ||
</EuiLink> | ||
), | ||
}} | ||
/> | ||
</p> | ||
<p> | ||
<EuiLink | ||
data-test-subj="assetDetailsTitleHasSystemMetricsLearnMoreLink" | ||
href={APM_HOST_TROUBLESHOOTING_LINK} | ||
target="_blank" | ||
> | ||
<FormattedMessage | ||
id="xpack.infra.assetDetails.title.tooltip.learnMoreLink" | ||
defaultMessage="Learn more" | ||
/> | ||
</EuiLink> | ||
</p> | ||
</EuiText> | ||
</Popover> | ||
</EuiFlexItem> | ||
</EuiFlexGroup> | ||
) : ( | ||
<>{name}</> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will block the loading of components in the flyout that doesn't depend on metadata.
blocking_loading_spinner.mov
This is not necessarily part of this PR, but how about removing this
InfraLoadingPanel
and passingloading
andmetadataLoading
via props toFlyoutHeader
? This way we can have a loading spinner that doesn't block the loading rest of the flyout.For the full page view, we do this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting that! I changed it to use the loading spinner inside
FlyoutHeader
like on the page view:flyout_loading.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great now! thanks.