[Stateful sidenav] Don't fetch active space on unauthenticated routes #190408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
|
/ci |
💚 Build Succeeded
Metrics [docs]Page load bundle
To update your PR or re-run it, just comment with: cc @sebelga |
tsullivan
approved these changes
Aug 13, 2024
|
Thanks for the quick review @tsullivan ! 👍 |
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 13, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Aug 14, 2024
…elastic#190408) (cherry picked from commit 8dee365) # Conflicts: # src/plugins/navigation/public/plugin.test.ts # src/plugins/navigation/public/plugin.tsx # src/plugins/navigation/server/ui_settings.test.ts # src/plugins/navigation/server/ui_settings.ts
sebelga
added a commit
that referenced
this pull request
Aug 14, 2024
… routes (#190408) (#190487) # Backport This will backport the following commits from `main` to `8.15`: - [[Stateful sidenav] Don't fetch active space on unauthenticated routes (#190408)](#190408) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"sebastien.loix@elastic.co"},"sourceCommit":{"committedDate":"2024-08-13T16:00:08Z","message":"[Stateful sidenav] Don't fetch active space on unauthenticated routes (#190408)","sha":"8dee365bda57a324d18fbd9405a965f74f1c047f","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:SharedUX","backport:prev-minor","Feature:Chrome","v8.16.0","v8.15.1"],"number":190408,"url":"https://github.com/elastic/kibana/pull/190408","mergeCommit":{"message":"[Stateful sidenav] Don't fetch active space on unauthenticated routes (#190408)","sha":"8dee365bda57a324d18fbd9405a965f74f1c047f"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190408","number":190408,"mergeCommit":{"message":"[Stateful sidenav] Don't fetch active space on unauthenticated routes (#190408)","sha":"8dee365bda57a324d18fbd9405a965f74f1c047f"}},{"branch":"8.15","label":"v8.15.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the
navigationplugin tries to fetch the active space on unauthenticated routes (e.g. the login page). This created noise in the log and could mis lead users that something was wrong.For context, the navigation plugin fetches the active space on the client to decide which side navigation to render and on the server to decide which default route to redirect for the space home page.
Fixes #190135