Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] unskip visualize flaky tests #190249

Merged
merged 8 commits into from
Aug 15, 2024
Merged

[Visualize] unskip visualize flaky tests #190249

merged 8 commits into from
Aug 15, 2024

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Aug 9, 2024 •
edited by kibanamachine
Loading

Summary

Fixes #181884
Fixes #181883
Fixes #181895
Fixes #181881

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) v8.15.0 v8.16.0 and removed v8.15.0 labels Aug 9, 2024
@mbondyra mbondyra force-pushed the unskip_visualize branch 3 times, most recently from 95978f3 to 0c30c3b Compare August 14, 2024 13:18
@elastic elastic deleted a comment from kibanamachine Aug 15, 2024
@elastic elastic deleted a comment from kibanamachine Aug 15, 2024
@elastic elastic deleted a comment from kibanamachine Aug 15, 2024
@elastic elastic deleted a comment from kibanamachine Aug 15, 2024
@elastic elastic deleted a comment from kibanamachine Aug 15, 2024
@elastic elastic deleted a comment from kibanamachine Aug 15, 2024
@elastic elastic deleted a comment from kibanamachine Aug 15, 2024
@elastic elastic deleted a comment from kibanamachine Aug 15, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6778

[✅] test/functional/apps/visualize/group2/config.ts: 25/25 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6779

[✅] test/functional/apps/visualize/group2/config.ts: 25/25 tests passed.

see run history

@mbondyra mbondyra marked this pull request as ready for review August 15, 2024 14:33
@mbondyra mbondyra requested a review from a team as a code owner August 15, 2024 14:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVislib 371.6KB 371.6KB +1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6783

[✅] test/functional/apps/visualize/group2/config.ts: 50/50 tests passed.
[✅] x-pack/test/functional/apps/lens/open_in_lens/agg_based/config.ts: 50/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6781

[✅] test/functional/apps/visualize/group2/config.ts: 100/100 tests passed.
[✅] x-pack/test/functional/apps/lens/open_in_lens/agg_based/config.ts: 100/100 tests passed.

see run history

@mbondyra mbondyra merged commit f27a477 into elastic:main Aug 15, 2024
19 checks passed
@mbondyra mbondyra deleted the unskip_visualize branch August 15, 2024 19:19
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 15, 2024
@mbondyra
[Visualize] unskip visualize flaky tests (elastic#190249)
7b63ddc 
## Summary

Fixes elastic#181884
Fixes elastic#181883
Fixes elastic#181895
Fixes elastic#181881

(cherry picked from commit f27a477)
@kibanamachine kibanamachine mentioned this pull request Aug 15, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 15, 2024
@kibanamachine @mbondyra
[8.15] [Visualize] unskip visualize flaky tests (#190249) (#190640)
a47ee36 
# Backport

This will backport the following commits from `main` to `8.15`:
- [[Visualize] unskip visualize flaky tests
(#190249)](#190249)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-08-15T19:19:49Z","message":"[Visualize]
unskip visualize flaky tests (#190249)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/181884\r\nFixes
https://github.com/elastic/kibana/issues/181883\r\nFixes
https://github.com/elastic/kibana/issues/181895\r\nFixes
https://github.com/elastic/kibana/issues/181881","sha":"f27a477719cff70c8f54049dfe1b4085d25cb356","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","backport:prev-minor","v8.16.0"],"title":"[Visualize]
unskip visualize flaky
tests","number":190249,"url":"https://github.com/elastic/kibana/pull/190249","mergeCommit":{"message":"[Visualize]
unskip visualize flaky tests (#190249)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/181884\r\nFixes
https://github.com/elastic/kibana/issues/181883\r\nFixes
https://github.com/elastic/kibana/issues/181895\r\nFixes
https://github.com/elastic/kibana/issues/181881","sha":"f27a477719cff70c8f54049dfe1b4085d25cb356"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190249","number":190249,"mergeCommit":{"message":"[Visualize]
unskip visualize flaky tests (#190249)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/181884\r\nFixes
https://github.com/elastic/kibana/issues/181883\r\nFixes
https://github.com/elastic/kibana/issues/181895\r\nFixes
https://github.com/elastic/kibana/issues/181881","sha":"f27a477719cff70c8f54049dfe1b4085d25cb356"}}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.15.1 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/open_in_lens/agg_based/gauge·ts - lens app - Agg based Vis Open in Lens Gauge should convert color ranges Failing test: Chrome UI Functional Tests.test/functional/apps/visualize/group2/_heatmap_chart·ts - visualize app heatmap chart "before all" hook for "should save and load" Failing test: Chrome UI Functional Tests.test/functional/apps/visualize/group2/_gauge_chart·ts - visualize app gauge chart should format the metric correctly in percentage mode Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/open_in_lens/agg_based/gauge·ts - lens app - Agg based Vis Open in Lens Gauge should convert aggregation with params
5 participants
@mbondyra @kibanamachine @elasticmachine @kibana-ci @nickofthyme