Move react controls into controls plugin

[nreese]

Move react_controls from examples plugin to controls plugin. This PR does not effect user facing features since it does not effect the legacy control group implementation or its usage. Future PRs will integrate the new control group with dashboard and ControlGroupRenderer and then remove the legacy control group implementation.

PR increases page load bundle size because of new action registration and the control group react embeddable registration. This will be a temporary increase as removing the legacy control group will remove the legacy embeddable factory registration, which is larger then react embeddable registration.

[nreese]

/ci

[nreese]

/ci

[nreese]

/ci

[nreese]

/ci

[nreese]

/ci

[nreese]

@elasticmachine merge upstream

[nreese]

/ci

[nreese]

/ci

[nreese]

@elasticmachine merge upstream

[nreese]

/ci

[nreese]

/ci

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[nreese]

/ci

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 6a85e1b

Failed CI Steps

• FTR Configs #63
• FTR Configs #93

Test Failures

• [job] [logs] FTR Configs #93 / serverless observability UI Observability Logs Explorer DataSourceSelector with installed integrations and uncategorized data streams when open on the integrations tab should display a list of installed integrations

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
controls	204	299	+95

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
controls	343	371	+28

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
controls	203.0KB	379.0KB	+176.0KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
controls	19	27	+8

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
controls	53.3KB	56.3KB	+2.9KB

Unknown metric groups

API count

id	before	after	diff
controls	351	380	+29

async chunk count

id	before	after	diff
controls	8	16	+8

ESLint disabled line counts

id	before	after	diff
controls	3	5	+2

References to deprecated APIs

id	before	after	diff
controls	22	23	+1

Total ESLint disabled count

id	before	after	diff
controls	3	5	+2

History

• 💔 Build #226826 failed 5b8c172
• 💔 Build #226810 failed aeae108
• 💔 Build #226794 failed 321359efddee277a7f416f483443a2334f1ee976
• 💔 Build #226706 failed 13acf42
• 💔 Build #226687 failed 9256c64

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[ThomThomson]

Changes LGTM! Thank you for paying attention to the bundle size, because it could have easily ballooned. Good to see the compatibility check split out into its own file.

Also ran the example plugin. Not necessary to fix in this PR, but I'm seeing one small issue there:

The first time you create a control, there is no Data view selected. In main, the control group gets this info from the Dashboard - so I assume this is just something that is missing so far and will be resolved when we move this new version back into the Dashboard.

[nreese]

The first time you create a control, there is no Data view selected. In main, the control group gets this info from the Dashboard - so I assume this is just something that is missing so far and will be resolved when we move this new version back into the Dashboard.

I already have a follow-up PR that resolves this and cleans up some types. Just want to limit the number of changes in this PR since its just supposed to be a move