Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Cases] Fix custom fields and push button flaky tests #190139

Merged

Conversation

js-jankisalvi
Copy link
Contributor

Summary

Fixes #176805

Updated getBy to findBy and added await waitFor for method calls.

Updated push_button.test.tsx as this build fail had both tests failing in it.

@js-jankisalvi js-jankisalvi added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.16.0 labels Aug 8, 2024
@js-jankisalvi js-jankisalvi self-assigned this Aug 8, 2024
@js-jankisalvi js-jankisalvi requested a review from a team as a code owner August 8, 2024 13:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @js-jankisalvi

@js-jankisalvi js-jankisalvi merged commit 3f8d1d7 into elastic:main Aug 9, 2024
20 checks passed
@js-jankisalvi js-jankisalvi deleted the fix-custom-fields-flaky-test branch August 9, 2024 08:22
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test: Jest Tests.x-pack/plugins/cases/public/components/custom_fields - CustomFields renders correctly
5 participants