[ES|QL] open the suggestion menu automatically in more places

[drewdaemon]

Summary

Closes #189662

Before

Screen.Recording.2024-07-30.at.4.51.29.PM.mov

After

Screen.Recording.2024-07-30.at.4.50.45.PM.mov

	Before	After
Source command	✅	✅
Pipe command	✅	✅
Function argument (when the minimum args aren't met)	❌	✅
Pipe |	❌	✅
Assignment var0 =	❌	✅
FROM source	❌	✅
FROM source METADATA	✅	✅
FROM source METADATA field	❌	❌
FROM source METADATA field,	❌	❌
EVAL argument	❌	❌
DISSECT field	❌	❌
DISSECT field pattern	❌	❌
DISSECT field pattern APPEND_SEPARATOR	✅	✅
DISSECT field pattern APPEND_SEPARATOR = separator	❌	❌
DROP field	❌	❌
DROP field1, field2	❌	❌
ENRICH policy	❌	❌
ENRICH policy ON	✅	✅
ENRICH policy ON field	❌	❌
ENRICH policy WITH	✅	✅
ENRICH policy WITH field	❌	❌
GROK field	❌	❌
GROK field pattern	❌	❌
KEEP field	❌	❌
KEEP field1, field2	❌	❌
LIMIT number	❌	✅
MV_EXPAND field	❌	❌
RENAME field	❌	❌
RENAME field AS	✅	✅
RENAME field AS var0	❌	❌
SORT field	❌	✅
SORT field order	❌	✅
SORT field order nulls-order	❌	✅
STATS argument	✅	✅
STATS argument BY	✅	✅
STATS argument BY expression	❌	✅
WHERE argument	❌	✅
WHERE argument comparison	✅	✅
WHERE argument comparison argument	❌	❌

Also made a couple of improvements

• Added support for Invoke completion triggers for subsequent function arguments (e.g. date_diff("day", <cursor here>))
• When you select a date in the date picker, your cursor is now advanced past the inserted date and the editor is refocused.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[drewdaemon]

/ci

[drewdaemon]

/ci

[elasticmachine]

Pinging @elastic/kibana-esql (Team:ESQL)

[stratoula]

This PR is awesome, improves the experience A LOT!

Something seems to be broken though

Here I am expecting the named params and the date picker to be suggested and they are not. This is how it looks in main

[stratoula]

Naming is hard but this is a very nice variable name!

[ryankeairns]

MUCH smoother. This rounds off some sharp edges and left me feeling like I got to a result much more quickly. Great update!

[drewdaemon]

/ci

[drewdaemon]

@stratoula I fixed that bug and added a test so that it doesn't happen again!

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: bdfbba8

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
esql	173.3KB	173.5KB	+242.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
kbnUiSharedDeps-srcJs	3.3MB	3.3MB	+1.0KB

History

• 💚 Build #226127 succeeded bdfbba8
• 💚 Build #225966 succeeded ad77eac
• 💔 Build #224875 failed 185b81c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[stratoula]

This is awesome Drew, thanx a ton. Great enhancement!

More ideas that we could explore:

• If the user selects an index and then comma, we could immediately open again the sources suggestions
• Similar with keep, if the user selects a field, then open the suggestions menu to select comma and then again fields etc. I am anticipating that the keep command will be quite popular

My suggestions are just ideas we could explore in another PR or at some other time. I am approving, this is great as it is already!