[Infra] Create endpoint to verify if there is data #189470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
bcdcc36 to
b4d2a7d
Compare
b4d2a7d to
be1770b
Compare
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
| .expect(expectedHttpStatusCode); | ||
| }; | ||
|
|
||
| before(() => patchRequest({ name: 'default', metricAlias: 'metrics-*,metricbeat-*' })); |
There was a problem hiding this comment.
I've seen much code in our repo that does this syntax, dropping the async / await.
Is there no worry of a timing issue?
There was a problem hiding this comment.
it returns a promise, jest should recognize it as an async operation a treat it accordingly
There was a problem hiding this comment.
Indeed, thanks for sharing your perspective.
There was a problem hiding this comment.
One question, can you tell me which Jest config this test is apart of?
dmlemeshko
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes 189247
Summary
Create an endpoint to return whether there is data for modules passed via
modulesquery param. Whenmodulesis not passed, the query will just check if there is any data in the index patterns configured in the Settings pageHow to test
node scripts/synthtrace infra_hosts_with_apm_hosts --liveGET kbn:/api/metrics/source/hasData?modules=kubernetes&modules=systemGET kbn:/api/metrics/source/hasData?modules=systemGET kbn:/api/metrics/source/hasData?modules=kubernetes&modules=system&modules=kafka&modules=aws&modules=azure- should return 400GET kbn:/api/metrics/source/hasData