Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix timeslice chaining in react embeddable control group #188866

Merged
merged 4 commits into from
Jul 29, 2024
Merged

fix timeslice chaining in react embeddable control group #188866

merged 4 commits into from
Jul 29, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jul 22, 2024

While reviewing #188687, I noticed that controls where still getting filtered by timeslider changes even when chaining was disabled or the control was to the left of the timeslider. This PR resolves this issue by only passing in timeslice from chaining$ instead of controlGroupFetch$.

@nreese
Copy link
Contributor Author

nreese commented Jul 22, 2024

/ci

@nreese nreese marked this pull request as ready for review July 22, 2024 16:52
@nreese nreese requested a review from a team as a code owner July 22, 2024 16:52
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes project:embeddableRebuild v8.16.0 labels Jul 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented Jul 24, 2024

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Jul 29, 2024

@elasticmachine merge upstream

Heenawter
Heenawter approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only - LGTM 👍 Makes sense that we shouldn't be doubling up on timeslice

@nreese
Copy link
Contributor Author

nreese commented Jul 29, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #7 / telemetry tasks endpoint-meta-telemetry should execute when scheduled
  • [job] [logs] Jest Tests #9 / TemplateTags renders loading state

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit c1070f3 into elastic:main Jul 29, 2024
22 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nreese @elasticmachine @kibana-ci @Heenawter @kibanamachine