Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] improve SORT command suggestions #188579

Merged
merged 3 commits into from
Jul 22, 2024
Merged

[ES|QL] improve SORT command suggestions #188579

merged 3 commits into from
Jul 22, 2024

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Jul 17, 2024 •
edited by kibanamachine
Loading

Summary

  • Suggests options in uppercase
  • Applies syntax highlighting

Before

Screen.Recording.2024-07-17.at.12.00.17.PM.mov

After

Screen.Recording.2024-07-17.at.11.58.21.AM.mov

@drewdaemon
Copy link
Contributor Author

/ci

@drewdaemon drewdaemon added Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Jul 17, 2024
@drewdaemon
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.2MB 3.2MB -30.0B

History

@drewdaemon drewdaemon marked this pull request as ready for review July 17, 2024 21:52
@drewdaemon drewdaemon requested a review from a team as a code owner July 17, 2024 21:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula
Copy link
Contributor

/ci

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 and removed release_note:fix labels Jul 22, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.2MB 3.2MB -30.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit 2438c36 into elastic:main Jul 22, 2024
42 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 22, 2024
@drewdaemon drewdaemon added backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) v8.15.0 and removed backport:skip This commit does not require backporting labels Jul 29, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 29, 2024
@drewdaemon
[ES|QL] improve SORT command suggestions (elastic#188579)
73c96e6 
## Summary

- Suggests options in uppercase
- Applies syntax highlighting

**Before**

https://github.com/user-attachments/assets/5f04d8fc-d61a-4779-906b-a7f4f42b4014

**After**

https://github.com/user-attachments/assets/cd585306-020a-4a55-867a-affe373666f6

---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
(cherry picked from commit 2438c36)
@kibanamachine kibanamachine mentioned this pull request Jul 29, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 30, 2024
@kibanamachine @drewdaemon
[8.15] [ES|QL] improve &#x60;SORT&#x60; command suggestions (#188579) (…
2099f4d 
…#189452)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[ES|QL] improve &#x60;SORT&#x60; command suggestions
(#188579)](#188579)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Drew
Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2024-07-22T14:06:27Z","message":"[ES|QL]
improve `SORT` command suggestions (#188579)\n\n## Summary\r\n\r\n-
Suggests options in uppercase\r\n- Applies syntax
highlighting\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/5f04d8fc-d61a-4779-906b-a7f4f42b4014\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/cd585306-020a-4a55-867a-affe373666f6\r\n\r\n---------\r\n\r\nCo-authored-by:
Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"2438c36fd9bfabad9b09775d031c8cdd3d43d105","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.15.0","v8.16.0"],"title":"[ES|QL]
improve `SORT` command
suggestions","number":188579,"url":"https://github.com/elastic/kibana/pull/188579","mergeCommit":{"message":"[ES|QL]
improve `SORT` command suggestions (#188579)\n\n## Summary\r\n\r\n-
Suggests options in uppercase\r\n- Applies syntax
highlighting\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/5f04d8fc-d61a-4779-906b-a7f4f42b4014\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/cd585306-020a-4a55-867a-affe373666f6\r\n\r\n---------\r\n\r\nCo-authored-by:
Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"2438c36fd9bfabad9b09775d031c8cdd3d43d105"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188579","number":188579,"mergeCommit":{"message":"[ES|QL]
improve `SORT` command suggestions (#188579)\n\n## Summary\r\n\r\n-
Suggests options in uppercase\r\n- Applies syntax
highlighting\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/5f04d8fc-d61a-4779-906b-a7f4f42b4014\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/cd585306-020a-4a55-867a-affe373666f6\r\n\r\n---------\r\n\r\nCo-authored-by:
Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"2438c36fd9bfabad9b09775d031c8cdd3d43d105"}}]}]
BACKPORT-->

---------

Co-authored-by: Drew Tate <drew.tate@elastic.co>
Co-authored-by: Drew Tate <drewctate@gmail.com>
@drewdaemon drewdaemon mentioned this pull request Aug 14, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.15.0 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drewdaemon @elasticmachine @stratoula @kibana-ci @kibanamachine