[APM] Elastic Entity Model enablement #187593

kpatticha · 2024-07-04T16:56:18Z

Summary

closes

https://github.com/elastic/observability-dev/issues/3724 (text update)
https://github.com/elastic/observability-dev/issues/3722 (link to survey)
[APM] Implement EEM workflow #187568

Basic workflow for enabling EEM in service inventory view

The empty states will be handled in different PR

When the user clicks on "try new" we set up the builtin service entities. There is an open PR [EEM] Update the builtin service entity definition #187021 to update the definition. [1]

with the right permissions

Screen.Recording.2024-07-09.at.21.16.35.mov

Without the right permissions

Screen.Recording.2024-07-09.at.21.17.23.mov

NOTE

[1] if you test this PR locally the metrics will be N/A. you need to update https://github.com/elastic/kibana/blob/bf45ddd9f4c48acea5fac61d07012110bd4f0f4b/x-pack/plugins/observability_solution/entity_manager/server/lib/entities/built_in/services.ts . Unless the PR 187021 is merged

elasticmachine · 2024-07-04T16:56:23Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

obltmachine · 2024-07-04T16:56:36Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

…fix'

crespocarlos · 2024-07-05T07:10:03Z

...plugins/observability_solution/apm/public/components/routing/templates/apm_main_template.tsx

-            <ServiceGroupsButtonGroup selectedNavButton={selectedNavButton} />
-          ) : null,
+        children: (
+          <EuiFlexGroup direction="column">


I don't know if this will actually happen but if none of the conditions below are met, there will be an empty div in the DOM.

You mean the component we pass as children? That won't happen unless we change the template params we pass. We pass showServiceGroupsNav in ServiceGroupTemplate which is used for the services

...ns/observability_solution/apm/public/components/routing/templates/service_group_template.tsx

...ins/observability_solution/apm/public/components/shared/entity_enablement/feedback_modal.tsx

…-enablement

roshan-elastic · 2024-07-08T17:05:52Z

Hey @kpatticha,

Looking good! Some feedback from me:

1. Ask your admin to turn on
I've been discussing with Chris DiStasio and I we'll need to give you an updated design on this. Should be trivial hopefully:

Current design

Note : You'll be dependent on the following docs request in order to finish this I believe:

[Request]: Entity-Centric Services observability-docs#4027

2. New Elastic Experience
Could we refer to this as the new experience (i.e. drop the 'Elastic')?

e.g. "Try our new experience!" and "You're viewing our new experience"

elastic/observability-dev#3722

smith · 2024-07-10T01:18:45Z

/oblt-deploy-serverless

jennypavlova

LGTM (code review only)

jennypavlova · 2024-07-10T09:12:23Z

...plugins/observability_solution/apm/public/components/routing/templates/apm_main_template.tsx

@@ -126,6 +129,7 @@ export function ApmMainTemplate({
  const pageHeaderTitle = (
    <EuiFlexGroup justifyContent="spaceBetween" wrap={true}>
      {pageHeader?.pageTitle ?? pageTitle}
+      <EuiFlexItem grow={false} />


Q: Why is this item needed?

kibanamachine · 2024-07-10T13:28:39Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6506

[❌] APM - Cypress: 0/2 tests passed.

see run history

…-enablement

elasticmachine · 2024-07-10T19:59:32Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 808a64e
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-187593-808a64e60e24
Observability Deployment

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1896	1902	+6
`entityManager`	6	7	+1
total			+7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`entityManager`	8	14	+6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.5MB	3.5MB	+7.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`apm`	35.3KB	35.4KB	+143.0B
`entityManager`	2.1KB	2.6KB	+516.0B
total			+659.0B

Unknown metric groups

API count

id	before	after	diff
`entityManager`	8	14	+6

History

kpatticha added 16 commits June 25, 2024 10:06

Add service for logs rate timeseries

a4379ef

Add service for logs error rate timeseries

0cbef3c

Add API test

539b8c1

Add api tests

d307334

Merge branch 'main' of github.com:elastic/kibana into logs-timeseries

4564a4f

wip

9b133db

Merge branch 'main' of github.com:elastic/kibana into logs-timeseries

40b74bf

Add log rate chart

143460f

display charts

89fc6db

Fix call out

42c8e7c

Fix dashboard

2f1f1a3

Fix TS and lint

789442b

wip

4d0f59a

Merge branch 'main' of github.com:elastic/kibana into eem-enablement

06f8c3e

Improve eem enablement workflow

55c44d7

Show feedback modal on restore

244da1a

kpatticha requested review from a team as code owners July 4, 2024 16:56

botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jul 4, 2024

kpatticha and others added 2 commits July 4, 2024 20:07

Handle unauthorised

0cbb85f

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

7d7a82c

…fix'

kpatticha marked this pull request as draft July 4, 2024 17:27

crespocarlos reviewed Jul 5, 2024

View reviewed changes

jloleysens approved these changes Jul 5, 2024

View reviewed changes

jloleysens self-requested a review July 5, 2024 11:33

kpatticha added 2 commits July 8, 2024 12:48

Address PR feedback

829cfb1

Fix lint

49427b5

Merge branch 'eem-enablement' of github.com:kpatticha/kibana into eem…

664e785

…-enablement

kpatticha and others added 6 commits July 9, 2024 19:07

Update text for the link and popover

3fc0fd5

Merge branch 'main' of github.com:elastic/kibana into eem-enablement

ec86fb0

Pixel perfect feedback modal

e305811

Update text for the unauthorised modal

76916e9

Add thank you survey

2f60139

elastic/observability-dev#3722

Merge branch 'main' into eem-enablement

884db4d

kpatticha marked this pull request as ready for review July 10, 2024 06:51

kpatticha requested a review from a team as a code owner July 10, 2024 06:51

kpatticha requested a review from crespocarlos July 10, 2024 06:52

kpatticha added v8.16.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 10, 2024

klacabane approved these changes Jul 10, 2024

View reviewed changes

kpatticha enabled auto-merge (squash) July 10, 2024 09:19

jennypavlova approved these changes Jul 10, 2024

View reviewed changes

Merge branch 'main' into eem-enablement

c9019f1

miltonhultgren changed the title ~~[APM] Elastic Entity enablement~~ [APM] Elastic Entity Model enablement Jul 10, 2024

Merge branch 'main' into eem-enablement

5f8ca54

kpatticha added 4 commits July 10, 2024 20:04

Use the last EEM index

65ca981

Merge branch 'eem-enablement' of github.com:kpatticha/kibana into eem…

083f5cd

…-enablement

Fix tests

3b1a7be

Update test

808a64e

kpatticha merged commit b682833 into elastic:main Jul 10, 2024
24 of 26 checks passed

kibanamachine added the backport:skip This commit does not require backporting label Jul 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Elastic Entity Model enablement #187593

[APM] Elastic Entity Model enablement #187593

kpatticha commented Jul 4, 2024 •

edited

Loading

elasticmachine commented Jul 4, 2024

obltmachine commented Jul 4, 2024

crespocarlos Jul 5, 2024

kpatticha Jul 8, 2024

roshan-elastic commented Jul 8, 2024

smith commented Jul 10, 2024

jennypavlova left a comment

jennypavlova Jul 10, 2024

kibanamachine commented Jul 10, 2024

elasticmachine commented Jul 10, 2024 •

edited

Loading

API count

[APM] Elastic Entity Model enablement #187593

[APM] Elastic Entity Model enablement #187593

Conversation

kpatticha commented Jul 4, 2024 • edited Loading

Summary

with the right permissions

Without the right permissions

NOTE

elasticmachine commented Jul 4, 2024

obltmachine commented Jul 4, 2024

🤖 GitHub comments

crespocarlos Jul 5, 2024

Choose a reason for hiding this comment

kpatticha Jul 8, 2024

Choose a reason for hiding this comment

roshan-elastic commented Jul 8, 2024

smith commented Jul 10, 2024

jennypavlova left a comment

Choose a reason for hiding this comment

jennypavlova Jul 10, 2024

Choose a reason for hiding this comment

kibanamachine commented Jul 10, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6506

elasticmachine commented Jul 10, 2024 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

kpatticha commented Jul 4, 2024 •

edited

Loading

elasticmachine commented Jul 10, 2024 •

edited

Loading