You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that this is leaking onto many plugins due to it being used in @kbn/ebt-tools.
Despite all the savings being declared as async. The reality is that core is in the list, and @kbn/ebt-tools is used during bootstrap to register the performance_metrics event type. So, essentially, we are always loading it during the initial paint.
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that this is leaking onto many plugins due to it being used in
@kbn/ebt-tools
.Despite all the savings being declared as async. The reality is that
core
is in the list, and@kbn/ebt-tools
is used during bootstrap to register theperformance_metrics
event type. So, essentially, we are always loading it during the initial paint.For maintainers