Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset Quality] Fix flaky summary test #186618

Merged
merged 9 commits into from
Jun 21, 2024
Merged

[Dataset Quality] Fix flaky summary test #186618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b34b9f1
Fix refresh table breaking for summary
achyutjhunjhunwala Jun 21, 2024
d1fdaeb
Add timeout to find
achyutjhunjhunwala Jun 21, 2024
ac496c4
Merge branch 'elastic:main' into main
achyutjhunjhunwala Jun 21, 2024
12cad21
Merge branch 'elastic:main' into main
achyutjhunjhunwala Jun 21, 2024
db7d63b
Revert "Add timeout to find"
achyutjhunjhunwala Jun 21, 2024
c3a2774
Revert "Fix refresh table breaking for summary"
achyutjhunjhunwala Jun 21, 2024
5652822
Add timeout to find
achyutjhunjhunwala Jun 21, 2024
57b7be3
Update time
achyutjhunjhunwala Jun 21, 2024
21865c5
Added ingest to before block
achyutjhunjhunwala Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/dataset_quality/dataset_quality_summary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid

describe('Dataset quality summary', () => {
before(async () => {
await synthtrace.index(getInitialTestLogs({ to, count: 4 }));
await PageObjects.datasetQuality.navigateTo();
});

Expand All @@ -57,8 +58,6 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
});

it('shows poor, degraded and good count as 0 and all dataset as healthy', async () => {
await synthtrace.index(getInitialTestLogs({ to, count: 4 }));
await PageObjects.datasetQuality.refreshTable();
const summary = await PageObjects.datasetQuality.parseSummaryPanel();
expect(summary).to.eql({
datasetHealthPoor: '0',
Expand Down
3 changes: 2 additions & 1 deletion x-pack/test/functional/page_objects/dataset_quality.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,8 @@ export function DatasetQualityPageObject({ getPageObjects, getService }: FtrProv

async refreshTable() {
const filtersContainer = await testSubjects.find(
testSubjectSelectors.datasetQualityFiltersContainer
testSubjectSelectors.datasetQualityFiltersContainer,
20 * 1000
);
const refreshButton = await filtersContainer.findByTestSubject(
testSubjectSelectors.superDatePickerApplyTimeButton
Expand Down