Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spaces] Updates to Spaces UIs, allow assign roles to Space #184697

Closed
wants to merge 174 commits into from
Closed

[Spaces] Updates to Spaces UIs, allow assign roles to Space #184697

wants to merge 174 commits into from

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Jun 4, 2024 •
edited
Loading

Summary

Epic link: https://github.com/elastic/kibana-team/issues/785

This changes bring a new design to the management of Spaces in Stack Management / Security. We have a new page to view the details of the Space, and new UX to assign Roles to a Space.

Checklist

Delete any items that are not applicable to this PR.

tsullivan added 2 commits June 3, 2024 14:17
@tsullivan
New Security Management page: View Space
7730412 
Warnings suppression

Add tabs

header grid and tabs

Settings button

fix Switch button

getContentForSpace

Enabled features

Assigned roles

View space tabs

useTabs hook

enabledFeatureCount / totalFeatureCount

Count of assigned roles

Assign role button

working routing for selected tab

Content tab: map app names for display and icon

New Security Management page: View Space

Warnings suppression

Add tabs

header grid and tabs

getContentForSpace

Enabled features

View space tabs

useTabs hook

Assign role button
@tsullivan
Content counts link to saved objects page
827c2b0
@tsullivan tsullivan changed the title Roles/details/spaces modal [Spaces] Updates to Spaces UIs, allow assign roles to Space Jun 4, 2024
@tsullivan tsullivan force-pushed the roles/details/spaces-modal branch from a9baa84 to 90862b1 Compare June 4, 2024 23:25
@tsullivan tsullivan added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! enhancement New value added to drive a business result ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment ci:cloud-persist-deployment Persist cloud deployment indefinitely labels Jun 7, 2024
eokoneyo and others added 14 commits August 28, 2024 15:27
@eokoneyo
fix logic for excluding roles already ppart of space
a50eade
@eokoneyo
fix logic with selectable items
ad1e526
@eokoneyo
add implementation for assigning custom roles privileges
f51800b
@eokoneyo
refactor logic for selecting role cutomization anchor
8be8076
@eokoneyo
UI cleanup
e91dff4
@kibanamachine @eokoneyo
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
1b7d516 
…fix'
@eokoneyo
fix failing tests
7f5cff9
@eokoneyo
UI tweaks
27b1428
@eokoneyo
add tests for view space provider
3fb9d8e
@kibanamachine @eokoneyo
[CI] Auto-commit changed files from 'node scripts/notice'
f18eba3 
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --fix'
@eokoneyo
add tests for space assign role privilege form
d29d066
@kibanamachine @eokoneyo
[CI] Auto-commit changed files from 'node scripts/notice'
7579ac5
@eokoneyo
pass appropriate types to component
18c0d83
@tsullivan
Merge pull request #14 from eokoneyo/assign-roles-to-space
ccd34f3 
Further improvements to spaces role assignment tab
@eokoneyo
Copy link
Contributor

/ci

@tsullivan
Copy link
Member Author

/ci

@tsullivan tsullivan force-pushed the roles/details/spaces-modal branch from 01c001e to 467bea8 Compare August 30, 2024 00:45
@tsullivan
Copy link
Member Author

/ci

@tsullivan
Copy link
Member Author

Replaced with #191795

@tsullivan tsullivan closed this Aug 30, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 30, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #14 / DeleteSpacesButton renders as expected
  • [job] [logs] Jest Tests #14 / DeleteSpacesButton renders as expected

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
spaces 277 335 +58

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/security-plugin-types-public 31 34 +3
spaces 67 71 +4
total +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 589.1KB 590.2KB +1.2KB
spaces 185.1KB 247.1KB +62.0KB
total +63.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
spaces 0 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
security 67.3KB 67.5KB +243.0B
spaces 29.6KB 30.4KB +797.0B
total +1.0KB
Unknown metric groups

API count

id before after diff
@kbn/security-plugin-types-public 58 61 +3
spaces 261 265 +4
total +7

async chunk count

id before after diff
spaces 11 16 +5

ESLint disabled line counts

id before after diff
spaces 3 9 +6

Total ESLint disabled count

id before after diff
spaces 3 9 +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tsullivan @eokoneyo

@tsullivan tsullivan deleted the roles/details/spaces-modal branch August 30, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tsullivan tsullivan

@eokoneyo eokoneyo

Labels
ci:cloud-deploy Create or update a Cloud deployment ci:cloud-persist-deployment Persist cloud deployment indefinitely ci:cloud-redeploy Always create a new Cloud deployment enhancement New value added to drive a business result Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tsullivan @ek-so @eokoneyo @kibana-ci @kibanamachine @elasticmachine