[ES|QL] Render a Discover-like table in the assistant instead of a Lens chart #184106

stratoula · 2024-05-23T11:49:41Z

Summary

This PR does 2 things:

Creates a new plugin that is a wrapper of the unified datatable and is only for rendering as a table ES|QL results. The UnifiedDatatable package is good but the consumers need to know all the properties to understand how to use it and the necessity of displaying in a table the results of an ES|QL query comes a lot lately. This plugin has only 3 required properties (rows, columns, query) which make it very easy for the consumers to use it. It also integrates the Row Viewer flyout
It changes the implementation of the obs ai assistant to render a Discover like table instead of a Lens table. The Discover-like table is much better on rendering a table with thousands of columns and is going to be much more helpful for our users.

The same plugin can be used later for the inline ediitng flyout too in a dashboard if we want to also display the results of an ES|QL query.

Some screenshots of the new possibilities in the assistant:

I can see the results of an ES|QL query in a visualization

I can render my results as a Document view

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

…fix'

…ocs'

…fix'

src/plugins/esql_datagrid/kibana.jsonc

src/plugins/esql_datagrid/public/create_datagrid.tsx

jughosta

Hi @stratoula,

I have not checked the fully yet but leaving some initial questions.

packages/kbn-unified-data-table/src/components/data_table.tsx

src/plugins/esql_datagrid/public/data_grid.tsx

src/plugins/esql_datagrid/public/row_viewer.tsx

stratoula · 2024-06-04T09:41:37Z

/ci

jughosta

Looks great, thanks!

drewdaemon

Awesome simplification!

src/plugins/discover/public/hooks/use_navigation_props.tsx

drewdaemon · 2024-06-04T14:33:44Z

src/plugins/esql_datagrid/README.md

+<ESQLDataGrid
+  rows={values}
+  columns={formattedColumns}
+  dataView={adHocDataView}
+  query={{ esql: query }}
+  flyoutType="overlay"
+  isTableView
+/>


👍 so simple and nice!

...servability_solution/observability_ai_assistant_app/public/functions/visualize_esql.test.tsx

...bility_solution/observability_ai_assistant_app/server/functions/query/validate_esql_query.ts

stratoula · 2024-06-04T15:45:19Z

/ci

...ns/observability_solution/observability_ai_assistant_app/public/functions/visualize_esql.tsx

dgieselaar

🤲🏻

stratoula · 2024-06-05T16:49:51Z

@elasticmachine merge upstream

stratoula · 2024-06-05T16:50:08Z

/ci

kibana-ci · 2024-06-05T17:47:31Z

💔 Build Failed

Buildkite Build
Commit: 2f5593e
Interpreting CI Failures
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-184106-2f5593e7c7ce
Observability Deployment

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #50 / Monitoring Endpoints Kibana Overview Package (metrics-*) should get kibana rules at cluster level
[job] [logs] FTR Configs #50 / Monitoring Endpoints Kibana Overview Package (metrics-*) should get kibana rules at cluster level

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`esqlDataGrid`	-	396	+396

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/unified-data-table`	80	81	+1
`esqlDataGrid`	-	2	+2
total			+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cloudSecurityPosture`	448.7KB	448.9KB	+109.0B
`discover`	808.2KB	808.3KB	+110.0B
`esqlDataGrid`	-	118.6KB	+118.6KB
`observabilityAIAssistantApp`	151.4KB	152.8KB	+1.4KB
`securitySolution`	13.6MB	13.6MB	+550.0B
`slo`	858.1KB	858.2KB	+109.0B
total			+120.9KB

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	-	5499	+5499
`total size`	-	8.9MB	+8.9MB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/unified-data-table`	2	1	-1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`esqlDataGrid`	-	9.3KB	+9.3KB
`observabilityAIAssistantApp`	12.4KB	12.5KB	+143.0B
total			+9.4KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/unified-data-table`	152	153	+1
`esqlDataGrid`	-	2	+2
total			+3

async chunk count

id	before	after	diff
`esqlDataGrid`	-	5	+5

ESLint disabled line counts

id	before	after	diff
`esqlDataGrid`	-	2	+2

Total ESLint disabled count

id	before	after	diff
`esqlDataGrid`	-	2	+2

History

💛 Build #214228 was flaky 2f5593e
💔 Build #214205 failed d4283b5
💔 Build #214163 failed a8a7c46
💛 Build #213919 was flaky 81354e2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stratoula and others added 23 commits May 23, 2024 13:49

[ES|QL] Datatable plugin

164983b

Revert

684e6a7

Further fixes

42b18db

Merge branch 'main' into render-esql-discover-table

4ee57fe

Make more improvements and fix bugs

e077bed

Add some features

3998a3b

Fixes

412a7ad

A small note

76b2cd1

Merge branch 'main' into render-esql-discover-table

223046a

Merge branch 'main' into render-esql-discover-table

7a48660

Some small tweaks

123c419

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

7cac401

…fix'

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

1035072

Merge branch 'main' into render-esql-discover-table

9a9c665

[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…

b00ed54

…ocs'

add the new plugin to limits

9cc9e0a

Update limits

bb2cb8e

Dont import the flyout from Discover

2fee661

No reason to export

082a25e

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

70af376

…fix'

Fix check types

be4fa36

Smaller bundle size

3790a34

Remove unecseccary chank

cc37922

stratoula changed the title ~~[ES|QL] Datatable plugin~~ [ES|QL] Render a Discover table in the assistant instead of a Lens chart May 28, 2024

kibanamachine and others added 6 commits May 28, 2024 06:47

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

128bca3

…fix'

Small change

4000e33

Merge branch 'main' into render-esql-discover-table

ff88b28

Some fixes

02e3f71

Make the flyout type a prop

88a0a54

Add table in the Lens embeddable

fb8054f

botelastic bot added the ci:project-deploy-observability Create an Observability project label May 31, 2024

jbudz approved these changes May 31, 2024

View reviewed changes

afharo approved these changes May 31, 2024

View reviewed changes

src/plugins/esql_datagrid/kibana.jsonc Show resolved Hide resolved

stratoula added 3 commits June 1, 2024 09:59

Address comments

da816e8

Rename the function and small changes

386471a

Merge branch 'main' into render-esql-discover-table

58553e4

dgieselaar reviewed Jun 3, 2024

View reviewed changes

src/plugins/esql_datagrid/public/create_datagrid.tsx Outdated Show resolved Hide resolved

Address PR feedback

7b0e6c4

jughosta reviewed Jun 3, 2024

View reviewed changes

stratoula added 2 commits June 3, 2024 16:37

Apply

a04d11e

Merge branch 'main' into render-esql-discover-table

93d3f5f

jughosta requested a review from a team June 4, 2024 08:52

stratoula added 2 commits June 4, 2024 11:21

Address PR comments

39010c4

nit pick

723db18

jughosta approved these changes Jun 4, 2024

View reviewed changes

drewdaemon approved these changes Jun 4, 2024

View reviewed changes

stratoula added 2 commits June 4, 2024 17:33

Revert changes

e593d00

USe findByTestId instead

81354e2

dgieselaar reviewed Jun 5, 2024

View reviewed changes

...ns/observability_solution/observability_ai_assistant_app/public/functions/visualize_esql.tsx Outdated Show resolved Hide resolved

dgieselaar approved these changes Jun 5, 2024

View reviewed changes

stratoula added 3 commits June 5, 2024 16:13

Ready to merge

469de5e

Merge branch 'main' into render-esql-discover-table

a8a7c46

Merge branch 'main' into render-esql-discover-table

d4283b5

Merge branch 'main' into render-esql-discover-table

2f5593e

stratoula merged commit 5860259 into elastic:main Jun 5, 2024
35 of 38 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ES|QL] Render a Discover-like table in the assistant instead of a Lens chart #184106

[ES|QL] Render a Discover-like table in the assistant instead of a Lens chart #184106

stratoula commented May 23, 2024 •

edited

Loading

jughosta left a comment

stratoula commented Jun 4, 2024

jughosta left a comment

drewdaemon left a comment

drewdaemon Jun 4, 2024

kertal Jun 5, 2024

stratoula commented Jun 4, 2024

dgieselaar left a comment

stratoula commented Jun 5, 2024

stratoula commented Jun 5, 2024

kibana-ci commented Jun 5, 2024 •

edited

Loading

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

[ES|QL] Render a Discover-like table in the assistant instead of a Lens chart #184106

[ES|QL] Render a Discover-like table in the assistant instead of a Lens chart #184106

Conversation

stratoula commented May 23, 2024 • edited Loading

Summary

Checklist

jughosta left a comment

Choose a reason for hiding this comment

stratoula commented Jun 4, 2024

jughosta left a comment

Choose a reason for hiding this comment

drewdaemon left a comment

Choose a reason for hiding this comment

drewdaemon Jun 4, 2024

Choose a reason for hiding this comment

kertal Jun 5, 2024

Choose a reason for hiding this comment

stratoula commented Jun 4, 2024

dgieselaar left a comment

Choose a reason for hiding this comment

stratoula commented Jun 5, 2024

stratoula commented Jun 5, 2024

kibana-ci commented Jun 5, 2024 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Canvas Sharable Runtime

Public APIs missing exports

Page load bundle

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

History

stratoula commented May 23, 2024 •

edited

Loading

kibana-ci commented Jun 5, 2024 •

edited

Loading