Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Response Ops][Rule Form V2] Rule Form V2: Rule Form Page and State Management #183461

Closed
wants to merge 17 commits into from
Closed

[Response Ops][Rule Form V2] Rule Form V2: Rule Form Page and State Management #183461

wants to merge 17 commits into from

Conversation

JiaweiWu
Copy link
Contributor

Summary

Issue: #179105
Related PR: #180539

Part 3/3 PRs of the new rule form. This PR adds the full form page as well as state management using context and useReducers

I have also created a example plugin to demonstrate this PR. To access:

  1. Run the branch with yarn start --run-examples
  2. Navigate to http://localhost:5601/app/triggersActionsUiExample/rule_definition
    And you should be able to play around with the components in this PR:
Screenshot 2024-05-14 at 8 27 00 PM

Checklist

@JiaweiWu JiaweiWu added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.15.0 labels May 15, 2024
@JiaweiWu JiaweiWu requested a review from a team as a code owner May 15, 2024 03:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@JiaweiWu JiaweiWu requested review from a team as code owners June 6, 2024 04:32
@JiaweiWu JiaweiWu requested review from a team as code owners June 6, 2024 04:32
@JiaweiWu JiaweiWu requested a review from rylnd June 6, 2024 04:32
@JiaweiWu
Copy link
Contributor Author

JiaweiWu commented Jun 6, 2024

Sorry, bad merge! Closing this PR

@JiaweiWu JiaweiWu closed this Jun 6, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 6, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@JiaweiWu JiaweiWu deleted the rule-form-v2-full-page branch June 6, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd Awaiting requested review from rylnd rylnd was automatically assigned from elastic/security-detection-engine

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JiaweiWu @elasticmachine @kibana-ci @kibanamachine