[Serverless] Fixup config typos #180127
Merged
[Serverless] Fixup config typos #180127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on something else, I noticed what I presume are errors.
Further, regarding "x-pack/test_serverless/functional/test_suites/search/common_configs/config.group4.ts", there is no "../../common/visualizations/group4"
Not sure what to do here:
```
ERROR
/Users/trezworkbox/dev/main.worktrees/common-group-fixup/x-pack/test_serverless/functional/test_suites/search/common_configs/config.group4.ts
15:33 error Unable to resolve import [../../common/visualizations/group4] @kbn/imports/no_unresolvable_imports
✖ 1 problem (1 error, 0 warnings)
ERROR [eslint] errors
```
|
/ci |
|
@dmlemeshko whatcha think mate?
Should something else be here? |
pheyos
requested changes
Apr 5, 2024
x-pack/test_serverless/functional/test_suites/search/common_configs/config.group3.ts
Outdated
Show resolved
Hide resolved
x-pack/test_serverless/functional/test_suites/search/common_configs/config.group3.ts
Show resolved
Hide resolved
x-pack/test_serverless/functional/test_suites/search/common_configs/config.group4.ts
Outdated
Show resolved
Hide resolved
x-pack/test_serverless/functional/test_suites/search/common_configs/config.group4.ts
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixup Junit report names to match the file names.