[Cases] Case action: Integration tests

packages/kbn-check-mappings-update-cli/current_mappings.json

@@ -669,6 +669,34 @@
       }
     }
   },
+  "cases-oracle": {
+    "dynamic": false,
+    "properties": {
+      "cases": {
+        "properties": {
+          "id": {
+            "type": "keyword"
+          }
+        }
+      },
+      "counter": {
+        "type": "unsigned_long"
+      },
+      "createdAt": {
+        "type": "date"
+      },
+      "rules": {
+        "properties": {
+          "id": {
+            "type": "keyword"
+          }
+        }
+      },
+      "updatedAt": {
+        "type": "date"
+      }
+    }
+  },
   "cases-telemetry": {
     "dynamic": false,
     "properties": {}

x-pack/plugins/actions/server/integration_tests/mocks/connector_types.ts

@@ -29,4 +29,5 @@ export const connectorTypes: string[] = [
   '.bedrock',
   '.d3security',
   '.sentinelone',
+  '.cases',
 ];

x-pack/plugins/cases/server/connectors/cases/cases_connector.test.ts

@@ -5,6 +5,7 @@
  * 2.0.
  */
 
+import Boom from '@hapi/boom';
 import { actionsMock } from '@kbn/actions-plugin/server/mocks';
 import { actionsConfigMock } from '@kbn/actions-plugin/server/actions_config.mock';
 import { loggingSystemMock } from '@kbn/core-logging-server-mocks';
@@ -45,14 +46,15 @@ describe('CasesConnector', () => {
   const mockExecute = jest.fn();
   const getCasesClient = jest.fn().mockResolvedValue({ foo: 'bar' });
   const getSpaceId = jest.fn().mockReturnValue('default');
+  const getUnsecuredSavedObjectsClient = jest.fn();
   // 1ms delay before retrying
   const nextBackOff = jest.fn().mockReturnValue(1);
 
   const backOffFactory = {
     create: () => ({ nextBackOff }),
   };
 
-  const casesParams = { getCasesClient, getSpaceId };
+  const casesParams = { getCasesClient, getSpaceId, getUnsecuredSavedObjectsClient };
   const connectorParams = {
     configurationUtilities: actionsConfigMock.create(),
     config: {},
@@ -85,7 +87,7 @@ describe('CasesConnector', () => {
 
   it('creates the CasesConnectorExecutor correctly', async () => {
     await connector.run({
-      alerts: [],
+      alerts: [{ _id: 'alert-id-0', _index: 'alert-index-0' }],
       groupingBy,
       owner,
       rule,
@@ -105,7 +107,7 @@ describe('CasesConnector', () => {
 
   it('executes the CasesConnectorExecutor correctly', async () => {
     await connector.run({
-      alerts: [],
+      alerts: [{ _id: 'alert-id-0', _index: 'alert-index-0' }],
       groupingBy,
       owner,
       rule,
@@ -115,7 +117,7 @@ describe('CasesConnector', () => {
     });
 
     expect(mockExecute).toBeCalledWith({
-      alerts: [],
+      alerts: [{ _id: 'alert-id-0', _index: 'alert-index-0' }],
       groupingBy,
       owner,
       rule,
@@ -127,7 +129,7 @@ describe('CasesConnector', () => {
 
   it('creates the cases client correctly', async () => {
     await connector.run({
-      alerts: [],
+      alerts: [{ _id: 'alert-id-0', _index: 'alert-index-0' }],
       groupingBy,
       owner,
       rule,
@@ -144,7 +146,7 @@ describe('CasesConnector', () => {
 
     await expect(() =>
       connector.run({
-        alerts: [],
+        alerts: [{ _id: 'alert-id-0', _index: 'alert-index-0' }],
         groupingBy,
         owner,
         rule,
@@ -164,7 +166,7 @@ describe('CasesConnector', () => {
 
     await expect(() =>
       connector.run({
-        alerts: [],
+        alerts: [{ _id: 'alert-id-0', _index: 'alert-index-0' }],
         groupingBy,
         owner,
         rule,
@@ -184,7 +186,7 @@ describe('CasesConnector', () => {
 
     await expect(() =>
       connector.run({
-        alerts: [],
+        alerts: [{ _id: 'alert-id-0', _index: 'alert-index-0' }],
         groupingBy,
         owner,
         rule,
@@ -199,14 +201,36 @@ describe('CasesConnector', () => {
     );
   });
 
+  it('throws a CasesConnectorError when the executor throws a Boom error', async () => {
+    mockExecute.mockRejectedValue(
+      new Boom.Boom('Server error', { statusCode: 403, message: 'my error message' })
+    );
+
+    await expect(() =>
+      connector.run({
+        alerts: [{ _id: 'alert-id-0', _index: 'alert-index-0' }],
+        groupingBy,
+        owner,
+        rule,
+        timeWindow,
+        reopenClosedCases,
+        maximumCasesToOpen,
+      })
+    ).rejects.toThrowErrorMatchingInlineSnapshot(`"Forbidden: Server error"`);
+
+    expect(logger.error.mock.calls[0][0]).toBe(
+      '[CasesConnector][run] Execution of case connector failed. Message: Forbidden: Server error. Status code: 403'
+    );
+  });
+
   it('retries correctly', async () => {
     mockExecute
       .mockRejectedValueOnce(new CasesConnectorError('Conflict error', 409))
       .mockRejectedValueOnce(new CasesConnectorError('ES Unavailable', 503))
       .mockResolvedValue({});
 
     await connector.run({
-      alerts: [],
+      alerts: [{ _id: 'alert-id-0', _index: 'alert-index-0' }],
       groupingBy,
       owner,
       rule,
@@ -227,7 +251,7 @@ describe('CasesConnector', () => {
 
     await expect(() =>
       connector.run({
-        alerts: [],
+        alerts: [{ _id: 'alert-id-0', _index: 'alert-index-0' }],
         groupingBy,
         owner,
         rule,
@@ -244,4 +268,21 @@ describe('CasesConnector', () => {
     expect(nextBackOff).toBeCalledTimes(0);
     expect(mockExecute).toBeCalledTimes(0);
   });
+
+  it('does not execute with no alerts', async () => {
+    await connector.run({
+      alerts: [],
+      groupingBy,
+      owner,
+      rule,
+      timeWindow,
+      reopenClosedCases,
+      maximumCasesToOpen,
+    });
+
+    expect(getCasesClient).not.toBeCalled();
+    expect(CasesConnectorExecutorMock).not.toBeCalled();
+    expect(mockExecute).not.toBeCalled();
+    expect(nextBackOff).not.toBeCalled();
+  });
 });

x-pack/plugins/cases/server/connectors/cases/cases_connector.ts

@@ -5,9 +5,12 @@
  * 2.0.
  */
 
+import Boom from '@hapi/boom';
 import type { ServiceParams } from '@kbn/actions-plugin/server';
 import { SubActionConnector } from '@kbn/actions-plugin/server';
 import type { KibanaRequest } from '@kbn/core-http-server';
+import type { SavedObjectsClientContract } from '@kbn/core/server';
+import { SAVED_OBJECT_TYPES } from '../../../common';
 import { CASES_CONNECTOR_SUB_ACTION } from './constants';
 import type { CasesConnectorConfig, CasesConnectorRunParams, CasesConnectorSecrets } from './types';
 import { CasesConnectorRunParamsSchema } from './schema';
@@ -22,32 +25,31 @@ import {
 import { CasesConnectorExecutor } from './cases_connector_executor';
 import { CaseConnectorRetryService } from './retry_service';
 import { fullJitterBackoffFactory } from './full_jitter_backoff';
+import { CASE_ORACLE_SAVED_OBJECT } from '../../../common/constants';
 
 interface CasesConnectorParams {
   connectorParams: ServiceParams<CasesConnectorConfig, CasesConnectorSecrets>;
   casesParams: {
     getCasesClient: (request: KibanaRequest) => Promise<CasesClient>;
     getSpaceId: (request?: KibanaRequest) => string;
+    getUnsecuredSavedObjectsClient: (
+      request: KibanaRequest,
+      savedObjectTypes: string[]
+    ) => Promise<SavedObjectsClientContract>;
   };
 }
 
 export class CasesConnector extends SubActionConnector<
   CasesConnectorConfig,
   CasesConnectorSecrets
 > {
-  private readonly casesOracleService: CasesOracleService;
   private readonly casesService: CasesService;
   private readonly retryService: CaseConnectorRetryService;
   private readonly casesParams: CasesConnectorParams['casesParams'];
 
   constructor({ connectorParams, casesParams }: CasesConnectorParams) {
     super(connectorParams);
 
-    this.casesOracleService = new CasesOracleService({
-      logger: this.logger,
-      savedObjectsClient: this.savedObjectsClient,
-    });
-
     this.casesService = new CasesService();
 
     /**
@@ -84,6 +86,16 @@ export class CasesConnector extends SubActionConnector<
       this.handleError(error);
     }
 
+    if (params.alerts.length === 0) {
+      this.logDebugCurrentState(
+        'start',
+        '[CasesConnector][_run] No alerts. Skipping execution.',
+        params
+      );
+
+      return;
+    }
+
     await this.retryService.retryWithBackoff(() => this._run(params));
   }
 
@@ -95,11 +107,21 @@ export class CasesConnector extends SubActionConnector<
        */
       const kibanaRequest = this.kibanaRequest as KibanaRequest;
       const casesClient = await this.casesParams.getCasesClient(kibanaRequest);
+      const savedObjectsClient = await this.casesParams.getUnsecuredSavedObjectsClient(
+        kibanaRequest,
+        [...SAVED_OBJECT_TYPES, CASE_ORACLE_SAVED_OBJECT]
+      );
+
       const spaceId = this.casesParams.getSpaceId(kibanaRequest);
 
+      const casesOracleService = new CasesOracleService({
+        logger: this.logger,
+        savedObjectsClient,
+      });
+
       const connectorExecutor = new CasesConnectorExecutor({
         logger: this.logger,
-        casesOracleService: this.casesOracleService,
+        casesOracleService,
         casesService: this.casesService,
         casesClient,
         spaceId,
@@ -141,6 +163,17 @@ export class CasesConnector extends SubActionConnector<
       throw caseConnectorError;
     }
 
+    if (Boom.isBoom(error)) {
+      const caseConnectorError = new CasesConnectorError(
+        `${error.output.payload.error}: ${error.output.payload.message}`,
+        error.output.statusCode
+      );
+
+      this.logError(caseConnectorError);
+
+      throw caseConnectorError;
+    }
+
     const caseConnectorError = new CasesConnectorError(error.message, 500);
     this.logError(caseConnectorError);