Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Custom threshold] Add dev documentation #177484

Merged
merged 4 commits into from
Feb 22, 2024
Merged

[Custom threshold] Add dev documentation #177484

merged 4 commits into from
Feb 22, 2024

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Feb 21, 2024 •
edited
Loading

Summary

Add a dev document about how to generate data and create a custom threshold rule.

@maryam-saeidi maryam-saeidi added the release_note:skip Skip the PR/issue when compiling release notes label Feb 21, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

kdelemme
kdelemme approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! screenshots are definitely a nice addition. Hopefully they don't become outdated too soon

@maryam-saeidi maryam-saeidi marked this pull request as ready for review February 22, 2024 08:05
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner February 22, 2024 08:05
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Feb 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@maryam-saeidi maryam-saeidi enabled auto-merge (squash) February 22, 2024 09:06
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

@maryam-saeidi maryam-saeidi merged commit 46952f8 into elastic:main Feb 22, 2024
19 checks passed
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Feb 22, 2024
@maryam-saeidi maryam-saeidi deleted the chore/doc-custom-threshold branch February 22, 2024 13:50
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@maryam-saeidi @fkanout
[Custom threshold] Add dev documentation (elastic#177484)
51d46da 
## Summary

Add a dev document about how to generate data and create a custom
threshold rule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelemme kdelemme kdelemme approved these changes

Assignees

@kdelemme kdelemme

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maryam-saeidi @apmmachine @elasticmachine @kibana-ci @kdelemme @kibanamachine