fix: [Rules > Detection rules][AXE-CORE]: Buttons must have discernible text #177273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
@elasticmachine merge upstream |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
banderror
reviewed
Feb 21, 2024
...ugins/security_solution/public/detection_engine/rule_details_ui/pages/rule_details/index.tsx
Outdated
Show resolved
Hide resolved
banderror
reviewed
Feb 22, 2024
x-pack/plugins/security_solution/public/detections/components/rules/rule_switch/index.tsx
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 22, 2024
…le text (elastic#177273) Closes: elastic/security-team#8566 Closes: elastic/security-team#8569 ## Description The `<RuleSwitch />` component is currently flagged by the axe browser plugin for lacking text or an accessible label in its button switch. This pull request introduces support for the addition of the `aria-label` attribute to address this issue. Additionally, adjustments are made in two instances where this component is utilized within the codebase. ## Screens ### Axe report  ### A11y label  (cherry picked from commit 3db4a8f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 22, 2024
… discernible text (#177273) (#177636) # Backport This will backport the following commits from `main` to `8.13`: - [fix: [Rules > Detection rules][AXE-CORE]: Buttons must have discernible text (#177273)](#177273) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2024-02-22T18:33:10Z","message":"fix: [Rules > Detection rules][AXE-CORE]: Buttons must have discernible text (#177273)\n\nCloses: https://github.com/elastic/security-team/issues/8566\r\nCloses: https://github.com/elastic/security-team/issues/8569\r\n\r\n## Description\r\nThe `<RuleSwitch />` component is currently flagged by the axe browser\r\nplugin for lacking text or an accessible label in its button switch.\r\nThis pull request introduces support for the addition of the\r\n`aria-label` attribute to address this issue. Additionally, adjustments\r\nare made in two instances where this component is utilized within the\r\ncodebase.\r\n\r\n## Screens \r\n\r\n### Axe report \r\n\r\n\r\n\r\n### A11y label \r\n\r\n","sha":"3db4a8fa98b0e6968d40476505b6497559682fe5","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rule Management","Feature:Rule Details","v8.13.0","v8.14.0"],"title":"fix: [Rules > Detection rules][AXE-CORE]: Buttons must have discernible text","number":177273,"url":"https://github.com/elastic/kibana/pull/177273","mergeCommit":{"message":"fix: [Rules > Detection rules][AXE-CORE]: Buttons must have discernible text (#177273)\n\nCloses: https://github.com/elastic/security-team/issues/8566\r\nCloses: https://github.com/elastic/security-team/issues/8569\r\n\r\n## Description\r\nThe `<RuleSwitch />` component is currently flagged by the axe browser\r\nplugin for lacking text or an accessible label in its button switch.\r\nThis pull request introduces support for the addition of the\r\n`aria-label` attribute to address this issue. Additionally, adjustments\r\nare made in two instances where this component is utilized within the\r\ncodebase.\r\n\r\n## Screens \r\n\r\n### Axe report \r\n\r\n\r\n\r\n### A11y label \r\n\r\n","sha":"3db4a8fa98b0e6968d40476505b6497559682fe5"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177273","number":177273,"mergeCommit":{"message":"fix: [Rules > Detection rules][AXE-CORE]: Buttons must have discernible text (#177273)\n\nCloses: https://github.com/elastic/security-team/issues/8566\r\nCloses: https://github.com/elastic/security-team/issues/8569\r\n\r\n## Description\r\nThe `<RuleSwitch />` component is currently flagged by the axe browser\r\nplugin for lacking text or an accessible label in its button switch.\r\nThis pull request introduces support for the addition of the\r\n`aria-label` attribute to address this issue. Additionally, adjustments\r\nare made in two instances where this component is utilized within the\r\ncodebase.\r\n\r\n## Screens \r\n\r\n### Axe report \r\n\r\n\r\n\r\n### A11y label \r\n\r\n","sha":"3db4a8fa98b0e6968d40476505b6497559682fe5"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…le text (elastic#177273) Closes: elastic/security-team#8566 Closes: elastic/security-team#8569 ## Description The `<RuleSwitch />` component is currently flagged by the axe browser plugin for lacking text or an accessible label in its button switch. This pull request introduces support for the addition of the `aria-label` attribute to address this issue. Additionally, adjustments are made in two instances where this component is utilized within the codebase. ## Screens ### Axe report  ### A11y label 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/elastic/security-team/issues/8566
Closes: https://github.com/elastic/security-team/issues/8569
Description
The
<RuleSwitch />component is currently flagged by the axe browser plugin for lacking text or an accessible label in its button switch. This pull request introduces support for the addition of thearia-labelattribute to address this issue. Additionally, adjustments are made in two instances where this component is utilized within the codebase.Screens
Axe report
A11y label