[Cases] Fix property actions flaky tests #176709
Conversation
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
| ).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('renders the modal info correctly for one alert', async () => { |
There was a problem hiding this comment.
removed this test as it is already covered in remove alerts correctly
...cases/public/components/user_actions/property_actions/user_comment_property_actions.test.tsx
Show resolved
Hide resolved
| @@ -18,8 +18,7 @@ import { | |||
| import { RegisteredAttachmentsPropertyActions } from './registered_attachments_property_actions'; | |||
| import { AttachmentActionType } from '../../../client/attachment_framework/types'; | |||
|
|
|||
| // FLAKY: https://github.com/elastic/kibana/issues/174384 | |||
| describe.skip('RegisteredAttachmentsPropertyActions', () => { | |||
| describe('RegisteredAttachmentsPropertyActions', () => { | |||
There was a problem hiding this comment.
Is there anything we can do on this test suite to improve flakiness?
There was a problem hiding this comment.
I checked but couldn't find anything.
There was a problem hiding this comment.
The test that fails is called renders the correct number of actions with error Error: thrown: "Exceeded timeout of 5000 ms for a test.. Probably the waitForEuiPopoverOpen took time (it is the only one with a waitFor inside). I am wondering what if we remove it and wait for the component we expecting. Example: expect((await screen.findByTestId('property-actions-user-action-group')).toBeInTheDocument(). I am not sure if this will fix the flaky test. It is just a speculation. Also,
expect((await screen.findByTestId('property-actions-user-action-group')).children.length).toBe(
1
);
can be substituted by expect((await screen.findByTestId('property-actions-user-action-group')).toBeInTheDocument() right?
There was a problem hiding this comment.
hmm.. I could give it a try.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
## Summary Fixes elastic#175314 Fixes elastic#175313 Fixes elastic#175312 Fixes elastic#175311 Fixes elastic#175310 Fixes elastic#174667 Fixes elastic#174384 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary Fixes elastic#175314 Fixes elastic#175313 Fixes elastic#175312 Fixes elastic#175311 Fixes elastic#175310 Fixes elastic#174667 Fixes elastic#174384 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Summary
Fixes #175314
Fixes #175313
Fixes #175312
Fixes #175311
Fixes #175310
Fixes #174667
Fixes #174384
Checklist