[Entity Analytics] Show Asset Criticality in Risk Input Left Flyout #174638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
hop-dev
commented
Jan 11, 2024
...urity_solution/public/entity_analytics/components/asset_criticality/use_asset_criticality.ts
Show resolved
Hide resolved
|
/ci |
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
|
/ci |
tiansivive
approved these changes
Jan 15, 2024
...urity_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs.tsx
Outdated
Show resolved
Hide resolved
machadoum
reviewed
Jan 16, 2024
...urity_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs.tsx
Outdated
Show resolved
Hide resolved
...urity_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs.tsx
Outdated
Show resolved
Hide resolved
...urity_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs.tsx
Outdated
Show resolved
Hide resolved
..._solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs.test.tsx
Show resolved
Hide resolved
| @@ -67,6 +67,14 @@ describe( | |||
| expandRiskInputsFlyoutPanel(); | |||
| cy.get(RISK_INPUT_PANEL_HEADER).should('exist'); | |||
| }); | |||
|
|
|||
| it('should show asset criticality in the risk input panel', () => { | |||
| waitForAlerts(); | |||
There was a problem hiding this comment.
NIT: You can move the waitForAlerts() of all the tests to the beforeEach() hook.
| waitForAlerts(); | ||
| expandFirstAlertUserFlyout(); | ||
| expandRiskInputsFlyoutPanel(); | ||
| cy.get(ASSET_CRITICALITY_BADGE).should('exist'); |
There was a problem hiding this comment.
NIT: Below assertion is implicitly checking for the existence of the element, so this can be removed.
| waitForAlerts(); | ||
| expandFirstAlertHostFlyout(); | ||
| expandRiskInputsFlyoutPanel(); | ||
| cy.get(ASSET_CRITICALITY_BADGE).should('exist'); |
There was a problem hiding this comment.
NIT: Below assertion is implicitly checking for the existence of the element, so this can be removed.
MadameSheema
approved these changes
Jan 17, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @hop-dev |
|
Hey, great work! I see no obstacles in deploying this to production. However, for upcoming releases, I believe we can elevate it further by aligning these features more cohesively with other flyout designs. To achieve this, we should prioritize the asset criticality at the top of the flyout. Here's an example https://www.figma.com/file/IKQr6HbQPAdFws9i7Ikcx9/Entity-Analytics?type=design&node-id=473%3A25619&mode=design&t=juSE0rxLlaPUKbSk-1, Cheers! |
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…lastic#174638) ## Summary Show the asset criticality as part of the risk inputs under a new contexts section: <img width="1517" alt="Screenshot 2024-01-10 at 16 45 29" src="https://github.com/elastic/kibana/assets/3315046/4ab7fd16-2849-4d9c-8f1c-f9cd9b677e8f"> If there is no criticality assigned here is what it looks like: <img width="1098" alt="Screenshot 2024-01-10 at 12 05 28" src="https://github.com/elastic/kibana/assets/3315046/817e4397-1a3f-4e65-be27-dbadb364e693"> this is based off the criticality_level on the risk score document not the current asset criticality of the entity. ## Test steps Assign asset criticality to a host or user and raise alerts + a risk score for them, view the host details flyout and then expand risk inputs, the asset criticality at the time of the score should be shown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Show the asset criticality as part of the risk inputs under a new contexts section:
If there is no criticality assigned here is what it looks like:
this is based off the criticality_level on the risk score document not the current asset criticality of the entity.
Test steps
Assign asset criticality to a host or user and raise alerts + a risk score for them, view the host details flyout and then expand risk inputs, the asset criticality at the time of the score should be shown.