Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Move formula docs into separate package #173770

Merged
merged 15 commits into from
Jan 2, 2024
Merged

[Lens] Move formula docs into separate package #173770

merged 15 commits into from
Jan 2, 2024

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Dec 20, 2023

Summary

Fixes #103248 and #164952

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.13.0 labels Dec 20, 2023
@dej611
Copy link
Contributor Author

dej611 commented Dec 20, 2023

/ci

@dej611
Copy link
Contributor Author

dej611 commented Dec 21, 2023

/ci

@dej611
Copy link
Contributor Author

dej611 commented Dec 21, 2023

/ci

@dej611
Copy link
Contributor Author

dej611 commented Dec 21, 2023

/ci

@dej611
Copy link
Contributor Author

dej611 commented Dec 21, 2023

/ci

@dej611 dej611 marked this pull request as ready for review December 22, 2023 08:26
@dej611 dej611 requested review from a team as code owners December 22, 2023 08:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@dej611
Copy link
Contributor Author

dej611 commented Dec 22, 2023

/ci

@stratoula stratoula requested a review from dgieselaar December 22, 2023 13:17
@stratoula
Copy link
Contributor

/ci

stratoula
stratoula approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, tested it briefly localy in Chrome

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 1153 1187 +34

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/lens-formula-docs - 172 +172

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB +2.5KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/lens-formula-docs - 1 +1
Unknown metric groups

API count

id before after diff
@kbn/lens-formula-docs - 172 +172

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 99fc909 into elastic:main Jan 2, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 2, 2024
@dej611 dej611 mentioned this pull request Mar 26, 2024
Merged
1 task
dej611 added a commit that referenced this pull request Mar 26, 2024
@dej611
[Lens] Update time_range() function with an additional example (#179408)
7a9ccbb 
## Summary

Closes #164952 

Apparently part of the task was already done via #173770 but the issue
hasn't been updated.
I've now added one more example just to show a practical usage of
`time_range()` but the other 2 constant functions have already
meaningful examples in place.


### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@stratoula stratoula stratoula approved these changes

@dgieselaar dgieselaar Awaiting requested review from dgieselaar

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:build-webpack-bundle-analyzer Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens][GenAI] Make Lens formula function documentation available outside of Kibana
6 participants
@dej611 @elasticmachine @stratoula @kibana-ci @pgayvallet @kibanamachine