[Dataset quality] Implement Management Flyout #172136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
|
||
| const url = useMemo(() => { | ||
| const query = { | ||
| query: `data_stream.namespace : "${namespace}"`, |
There was a problem hiding this comment.
We should change this to use the new locator props once this PR is merged
|
|
||
| export const flyoutIntegrationTypeText = i18n.translate( | ||
| 'xpack.datasetQuality.flyoutIntegrationTypeText', | ||
| { |
There was a problem hiding this comment.
As per the new figma changes this should be Name instead of Type
| <EuiFlexGroup> | ||
| <EuiFlexItem grow={1}> | ||
| <EuiTitle size="xxs"> | ||
| <span>Namespace</span> |
There was a problem hiding this comment.
As per the comments on figma the namespace field should be removed
1fbb4c8 to
b043545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #170441
📝 Summary
This PR introduces the dataset quality flyout and shows the first 2 sections in the flyout, dataset and integration details. The new Actions column is also added as part of this PR.
✅ Testing
/app/observability-log-explorer/dataset-qualityOpen in Logs Exploreror theOpenAction column should navigate to the Log Explorer with having the correct dataset and namespace selected