-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adds E5 model configs #172053
[ML] Adds E5 model configs #172053
Conversation
Pinging @elastic/ml-ui (:ml) |
x-pack/packages/ml/trained_models_utils/src/constants/trained_models.ts
Outdated
Show resolved
Hide resolved
LGTM |
x-pack/plugins/ml/public/application/model_management/add_model_flyout.tsx
Outdated
Show resolved
Hide resolved
…l_flyout.tsx Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>
The Search team is going to use the follow text for copy, proposed by Steve D, it'd be nice if the flyout had the same copy :) E5 (EmbEddings from bidirEctional Encoder rEpresentations) is an NLP model that enables you to perform multi-lingual semantic search by using dense vector representations. This model performs best for non-English language documents and queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...s/search_index/pipelines/ml_inference/text_expansion_callout/text_expansion_callout_logic.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
x-pack/packages/ml/trained_models_utils/src/constants/trained_models.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security Solution/Assistant changes LGTM! Thanks @darnautov!
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @darnautov |
Apologies for just now looking at this. I know this is now merged (and we are at FF). So I'm dropping these comments here for visibility to those participating on this PR and happy to move them to a follow-up issue if it's easier. A few thoughts as we look at this flyout with both models added:
Here are two updated mocks (again, late to the party...sorry). Option 1
Option 2
|
@mdefazio - let's do a bit of user testing on it, and keep the tabs names as is. We can iterate quickly on this so we don't do unnecessary churn on FF right now. as long as we get the license link and documentation as we needed I feel comfortable taking what we have into the release. https://github.com/elastic/ml-team/issues/1075 (WDYT @arisonl ? ) |
@serenachou Sounds good. One last question though: Should E5 have a download link in the table, like ELSER? |
Nah, no need with this new button to add a model, we strike a good balance of having the primary callout for ELSER but the secondary be for e5 @mdefazio |
Summary
getCuratedModelConfig
shared service to retrieve the model ID and configuration appropriate for the current cluster architecture.name
property in theModelDefinitionResponse
interface withmodel_id
Checklist