-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Creates charts from the dashboard #171973
Conversation
/ci |
/ci |
/ci |
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
/ci |
/ci |
Hitting cancel still adds table panel. Steps:
|
src/plugins/dashboard/public/dashboard_app/top_nav/editor_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/dashboard/public/dashboard_app/top_nav/add_panel_action_menu_items.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well and Lens code LGTM
x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.tsx
Show resolved
Hide resolved
x-pack/plugins/lens/public/trigger_actions/open_lens_config/create_action.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.tsx
Outdated
Show resolved
Hide resolved
@nreese yes as long as the user does a change in the flyout, the Cancel button doesnt remove the panel. In my head, as long as the user starts editing things, they want to keep the panel. But as long as you find it confusing, I removed this logic and now the panel is removed whenever the user hits cancel |
/ci |
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana-presentation changes LGTM - Allowing users to create charts without leaving dashboard is a huge step forward and such a great feature.
code review, tested in chrome
Summary
Closes #165928
Enables the creation of ES|QL charts from the dashboard.
The implementation is using UIActions which I think is the correct way to register a new panel action to a dashboard. Lens is responsible to register the ESQL panel action and owns the code.
How it works
from <default_dataview_index_pattern> | limit 10
Checklist