Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Supress API key errors when we have no monitors #171085

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Nov 13, 2023

Summary

Supress API key errors when we have no monitors !!

Start a fresh cluster and make sure there is no API key errors in logs !!

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.12.0 v8.11.1 labels Nov 13, 2023
@shahzad31 shahzad31 marked this pull request as ready for review November 13, 2023 14:24
@shahzad31 shahzad31 requested a review from a team as a code owner November 13, 2023 14:24
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM!

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Nov 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 merged commit b71a52c into elastic:main Nov 13, 2023
9 checks passed
@shahzad31 shahzad31 deleted the api-key-error branch November 13, 2023 15:49
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 13, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 13, 2023
…171085) (#171109)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Synthetics] Supress API key errors when we have no monitors
(#171085)](#171085)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2023-11-13T15:49:18Z","message":"[Synthetics]
Supress API key errors when we have no monitors
(#171085)","sha":"b71a52c9f8ce739990d0cd360fc4d89d92a80b83","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.12.0","v8.11.1"],"number":171085,"url":"https://github.com/elastic/kibana/pull/171085","mergeCommit":{"message":"[Synthetics]
Supress API key errors when we have no monitors
(#171085)","sha":"b71a52c9f8ce739990d0cd360fc4d89d92a80b83"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171085","number":171085,"mergeCommit":{"message":"[Synthetics]
Supress API key errors when we have no monitors
(#171085)","sha":"b71a52c9f8ce739990d0cd360fc4d89d92a80b83"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
@mistic mistic added v8.11.2 and removed v8.11.1 labels Nov 14, 2023
@mistic
Copy link
Member

mistic commented Nov 14, 2023

This PR haven't made it into the latest BC of 8.11.1. Updating the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.11.2 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants