-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] AIOps Log Rate Analysis: Improve query generators #171008
[ML] AIOps Log Rate Analysis: Improve query generators #171008
Conversation
2c307b8
to
84ef32c
Compare
89ba1a9
to
ab4a63c
Compare
Pinging @elastic/ml-ui (:ml) |
x-pack/plugins/aiops/server/routes/log_rate_analysis/queries/get_query_with_params.test.ts
Show resolved
Hide resolved
x-pack/plugins/aiops/server/routes/log_rate_analysis/queries/fetch_categories.ts
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM.
As discussed, would be good to flag that the analysis needs to be rerun when changing the query in the query bar (known issue in #168459) for 8.12.
Code LGTM 🎉 |
@peteharverson I'll pick up the issue with the query bar in a follow up since the scope of this PR was server side only. |
Summary
Part of #168459.
Improves the query generation for some parts of log rate analysis and adds jest tests to verify the improvements.
Previously, some query generators were not concise enough with their checks and it could happen that for example range queries for the overall time range were added twice or that the range query for the overall time range was added although there were also range filters added for the inner baseline and deviation time range, for example:
The PR also unifies some mocks for the jest unit tests.
Checklist