-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] apis UI Counters UI remove dependency on date #170734
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It looks like we were setting dayDate
at the beginning of the test. So on midnight, some of the tests may run after midnight, and we'd be looking for the previous-day events.
This solution seems more rock-solid.
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Remove the dependency on serializing the day to find saved objects by id since this seems to be the source of flakiness.
I suspect it has to do with the timing of when the test was run or timezones because the CI was reported on October 3rd at 3 am but the counter shows October 2nd so it is failing to grab the saved object by id.
This change clears all saved objects before each test and searches for matching events by event name and counter name rather than serializing the saved object ID manually to find it.
Closes #98240