Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiered dependencies docs unrevert #169009

Merged

Conversation

jasonrhodes
Copy link
Member

#166524 was merged and then reverted with 9080836 because it failed a CI check for file name casing that wasn't run on the PR branch for some reason.

The file has now been properly snake_cased and this will re-apply the change.

This document explains the convention of "tiered dependencies" so we can begin to enforce it in code reviews by referencing a single document.
I've added a "summary" section near the top to try to clarify the way devs should approach organizing code in observability, keeping in mind the concerns that have been voiced by some devs already in this PR.
@jasonrhodes jasonrhodes requested a review from a team as a code owner October 16, 2023 17:24
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jasonrhodes jasonrhodes added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 16, 2023
@jasonrhodes jasonrhodes enabled auto-merge (squash) October 16, 2023 17:28
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonrhodes jasonrhodes merged commit 0526d79 into elastic:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants