Remove eslint-plugin-prefer-object-spread dependency #162439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Jul 24, 2023
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @watson |
stratoula
approved these changes
Jul 25, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 25, 2023
Remove the `eslint-plugin-prefer-object-spread` dependency as the `prefer-object-spread` rule has been part of ESLint since v5 (cherry picked from commit a79e9c7)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
watson
pushed a commit
to watson/kibana
that referenced
this pull request
Jul 25, 2023
Remove the `eslint-plugin-prefer-object-spread` dependency as the `prefer-object-spread` rule has been part of ESLint since v5 (cherry picked from commit a79e9c7) # Conflicts: # packages/kbn-tinymath/src/index.js
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 25, 2023
…162455) # Backport This will backport the following commits from `main` to `8.9`: - [Remove eslint-plugin-prefer-object-spread dependency (#162439)](#162439) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Thomas Watson","email":"watson@elastic.co"},"sourceCommit":{"committedDate":"2023-07-25T08:04:44Z","message":"Remove eslint-plugin-prefer-object-spread dependency (#162439)\n\nRemove the `eslint-plugin-prefer-object-spread` dependency as the\r\n`prefer-object-spread` rule has been part of ESLint since v5","sha":"a79e9c737498bc3f3bda3d82ef1b3387be88b9ed","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v7.17.10","v8.10.0","v7.17.12"],"number":162439,"url":"https://github.com/elastic/kibana/pull/162439","mergeCommit":{"message":"Remove eslint-plugin-prefer-object-spread dependency (#162439)\n\nRemove the `eslint-plugin-prefer-object-spread` dependency as the\r\n`prefer-object-spread` rule has been part of ESLint since v5","sha":"a79e9c737498bc3f3bda3d82ef1b3387be88b9ed"}},"sourceBranch":"main","suggestedTargetBranches":["7.17"],"targetPullRequestStates":[{"branch":"7.17","label":"v7.17.10","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162439","number":162439,"mergeCommit":{"message":"Remove eslint-plugin-prefer-object-spread dependency (#162439)\n\nRemove the `eslint-plugin-prefer-object-spread` dependency as the\r\n`prefer-object-spread` rule has been part of ESLint since v5","sha":"a79e9c737498bc3f3bda3d82ef1b3387be88b9ed"}}]}] BACKPORT--> Co-authored-by: Thomas Watson <watson@elastic.co>
watson
pushed a commit
that referenced
this pull request
Jul 25, 2023
…#162461) # Backport This will backport the following commits from `main` to `7.17`: - [Remove eslint-plugin-prefer-object-spread dependency (#162439)](#162439) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Thomas Watson","email":"watson@elastic.co"},"sourceCommit":{"committedDate":"2023-07-25T08:04:44Z","message":"Remove eslint-plugin-prefer-object-spread dependency (#162439)\n\nRemove the `eslint-plugin-prefer-object-spread` dependency as the\r\n`prefer-object-spread` rule has been part of ESLint since v5","sha":"a79e9c737498bc3f3bda3d82ef1b3387be88b9ed","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v8.10.0","v7.17.12"],"number":162439,"url":"https://github.com/elastic/kibana/pull/162439","mergeCommit":{"message":"Remove eslint-plugin-prefer-object-spread dependency (#162439)\n\nRemove the `eslint-plugin-prefer-object-spread` dependency as the\r\n`prefer-object-spread` rule has been part of ESLint since v5","sha":"a79e9c737498bc3f3bda3d82ef1b3387be88b9ed"}},"sourceBranch":"main","suggestedTargetBranches":["7.17"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162439","number":162439,"mergeCommit":{"message":"Remove eslint-plugin-prefer-object-spread dependency (#162439)\n\nRemove the `eslint-plugin-prefer-object-spread` dependency as the\r\n`prefer-object-spread` rule has been part of ESLint since v5","sha":"a79e9c737498bc3f3bda3d82ef1b3387be88b9ed"}},{"branch":"7.17","label":"v7.17.12","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"url":"https://github.com/elastic/kibana/pull/162455","number":162455,"branch":"8.9","state":"OPEN"}]}] BACKPORT-->
|
This PR didn't make it into the latest BC of 8.9.0 and 7.17.12. Updating the labels. |
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
Remove the `eslint-plugin-prefer-object-spread` dependency as the `prefer-object-spread` rule has been part of ESLint since v5
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
eslint-plugin-prefer-object-spreaddependency as theprefer-object-spreadrule has been part of ESLint since v5 (we currently run ESLint v7).