Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Support package capabilities filtering #162435

Merged
merged 9 commits into from
Jul 28, 2023
Merged

[Fleet] Support package capabilities filtering #162435

merged 9 commits into from
Jul 28, 2023

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jul 24, 2023 •
edited by jlind23
Loading

Summary

Depends on elastic/package-registry#1061

Pass the capabilities configured in xpack.fleet.internal.capabilities to the package registry to allow filtering on capabilities.

Manual test instructions

  • Using that custom package registry you can try to add elastic.capabilities to a package and xpack.fleet.internal.capabilities to you kibana.dev.yml file to see that filitering is correctly done.

Todo

  • automated tests
  • manual test instructions
  • Configure capabilities for observability and security project

Closes #161215

@nchaulet nchaulet self-assigned this Jul 24, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet nchaulet linked an issue Jul 24, 2023 that may be closed by this pull request
[Fleet] Search packages based on available features #161215
Closed
@nchaulet nchaulet force-pushed the feature-fleet-support-capabilities-filtering branch from e46e2c2 to 7c64029 Compare July 24, 2023 19:40
@nchaulet nchaulet added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 25, 2023
@nchaulet nchaulet marked this pull request as ready for review July 25, 2023 13:30
@nchaulet nchaulet requested a review from a team as a code owner July 25, 2023 13:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Jul 25, 2023
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@juliaElastic
Copy link
Contributor

Is this pr closing #161215 ?
How is this going to work in serverless, is xpack.fleet.internal.capabilities going to be set by project type or similar?

@nchaulet
Merge branch 'feature-fleet-support-capabilities-filtering' of github…
6e3f4d3 
….com:nchaulet/kibana into feature-fleet-support-capabilities-filtering
@nchaulet nchaulet requested a review from a team as a code owner July 25, 2023 14:58
@nchaulet
Copy link
Member Author

nchaulet commented Jul 25, 2023 •
edited
Loading

Is this pr closing #161215 ?

Yes it is

How is this going to work in serverless, is xpack.fleet.internal.capabilities going to be set by project type or similar?

Yes I just added a commit with the serverless.*.yml specific config per project

juliaElastic
juliaElastic approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsoriano
jsoriano reviewed Jul 26, 2023
View reviewed changes
@nchaulet @jsoriano
Update config/serverless.es.yml
8ddf458 
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #1 / Endpoint Policy Response from Fleet Agent Details page should display policy response with errors should display policy response with errors

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 9b89502 into elastic:main Jul 28, 2023
@nchaulet nchaulet deleted the feature-fleet-support-capabilities-filtering branch July 28, 2023 19:58
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 28, 2023
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
@nchaulet
[Fleet] Support package capabilities filtering (elastic#162435)
394ea6d
@jlind23 jlind23 mentioned this pull request Sep 13, 2023
Closed
@juliaElastic juliaElastic mentioned this pull request Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano left review comments

@pgayvallet pgayvallet pgayvallet approved these changes

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Search packages based on available features
8 participants
@nchaulet @apmmachine @elasticmachine @juliaElastic @kibana-ci @jsoriano @pgayvallet @kibanamachine