[Enterprise Search] De-couple Overview from ent-search #161995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
reviewed
Jul 17, 2023
...lic/applications/enterprise_search_overview/components/product_selector/product_selector.tsx
Outdated
Show resolved
Hide resolved
5e4a09e to
22239e1
Compare
Re-worked the enterprise search overview page to show a connection error callout on the page instead of the ErrorConnecting page. This also required ditching the "Insufficient permissions" view that we also wanted to get rid of. This is the initial part of updating the overview page to not be dependent on ent-search service.
22239e1 to
8ca456a
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsmiscellaneous assets size
History
To update your PR or re-run it, just comment with: |
sphilipse
approved these changes
Jul 18, 2023
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
## Summary Updated the Overview page to render an connection error callout instead of the full ErrorConnecting page. This allows us to render the Elasticsearch product card even without ent-search available. This required removing the "Insufficient permissions" view since we also always want to show the elasticsearch product card even if the user doesn't have access to app search and workplace search. ### Screenshots <img width="1530" alt="image" src="https://github.com/elastic/kibana/assets/1972968/2ad5b905-3f42-435b-81e5-a7d71ce8039e">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the Overview page to render an connection error callout instead of the full ErrorConnecting page. This allows us to render the Elasticsearch product card even without ent-search available.
This required removing the "Insufficient permissions" view since we also always want to show the elasticsearch product card even if the user doesn't have access to app search and workplace search.
Screenshots