Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix skip intro for elastic assistant #161723

Closed
wants to merge 1 commit into from
Closed

[Security Solution] Fix skip intro for elastic assistant #161723

wants to merge 1 commit into from

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Jul 12, 2023

Summary

This PR fixes issue #6992

@lgestc lgestc requested a review from a team as a code owner July 12, 2023 07:09
@lgestc lgestc added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 Feature:Security Assistant Security Assistant labels Jul 12, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jul 12, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.1MB 11.1MB -232.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

spong
spong reviewed Jul 12, 2023
View reviewed changes
x-pack/packages/kbn-elastic-assistant/impl/connectorland/connector_setup/index.tsx
bottomRef.current?.scrollIntoView({ block: 'end' });
if (currentMessageIndex >= MESSAGE_INDEX_BEFORE_CONNECTOR) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think this'll have a bug where the new enterprise messages would put it greater than MESSAGE_INDEX_BEFORE_CONNECTOR, so we we ended up switching to use the message length.

@lgestc lgestc marked this pull request as draft July 12, 2023 10:13
@lgestc lgestc closed this Jul 24, 2023
@sophiec20 sophiec20 deleted the bugfix-6992-revisited branch February 18, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong left review comments

Assignees
No one assigned
Labels
Feature:Security Assistant Security Assistant release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgestc @kibana-ci @spong