[Serverless] Update observability side navigation

[kpatticha]

Update once again the side navigation tree to match the latest mocks - https://www.figma.com/file/S4fn8L4j8fG1H6331Lw3kb/IA%2FNavigation?type=design&node-id=1265-151762&mode=design

Before

After

Screen.Recording.2023-06-29.at.12.39.02.mov

Notes for reviewers

• ML deep links will be visible after the [ML] Integrates into serverless kibana #159433

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[kpatticha]

The external links are not defined yet. I added the default https://cloud.elastic.co but we can remove them until we have the links

[yngrdyn]

I'm fine with it but maybe it'd be good to have an issue to not forget about this, wdyt?

[MiriamAparicio]

LGTM

[formgeist]

Is there a chance we can change the link color to text for these external links?

Can we remove the collapsible accordion for the Observability menu?

The Observability and gear icon can be reduced to 16px or if you're using the EuiIcon component to render the icons, it's the size m.

Thanks for getting all these changes in 🙏

[formgeist]

Probably not the right spot for a comment, but we can link to the /app/management app view. This will eventually be replaced with a director overview of the management options available for the project type.

[kpatticha]

good catch. Fixed it here

499459d

Screen.Recording.2023-06-30.at.11.12.59.mov

[kpatticha]

Is there a chance we can change the link color to text for these external links?

Can we remove the collapsible accordion for the Observability menu? The Observability and gear icon can be reduced to 16px or if you're using the `EuiIcon` component to render the icons, it's the size `m`.

These changes will require changing the shared navigation component. if you don't mind I will do it in a follow up PR to avoid blocking this work

[sebelga]

As I put in my comment, the "Project settings" should be exposed by the shared ux component as a preset so we can use it in other side nav.

[sabarasaba]

Changes in packages/deeplinks/management folder lgtm

[formgeist]

Is there a chance we can change the link color to text for these external links?

Can we remove the collapsible accordion for the Observability menu?

The Observability and gear icon can be reduced to 16px or if you're using the EuiIcon component to render the icons, it's the size m.

These changes will require changing the shared navigation component. if you don't mind I will do it in a follow up PR to avoid blocking this work

All good 👍

[kpatticha]

@elasticmachine merge upstream

[kpatticha]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: b4b7ed0

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
@kbn/deeplinks-management	2	0	-2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
serverlessObservability	21.7KB	22.4KB	+722.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	14	16	+2
securitySolution	411	415	+4
total			+6

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	15	17	+2
securitySolution	490	494	+4
total			+6

History

• 💚 Build #139389 succeeded 2c0dd67
• 💔 Build #139346 failed 499459d
• 💚 Build #139064 succeeded f306582
• 💔 Build #139061 failed 32c1e30

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[sebelga]

LGTM! Thanks 👍