Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Time axis] Deprecate the legacy time axis #160602

Merged
merged 2 commits into from
Jun 27, 2023
Merged

[Time axis] Deprecate the legacy time axis #160602

merged 2 commits into from
Jun 27, 2023

Conversation

mbondyra
Copy link
Contributor

Summary

Fixes #159088

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.10.0 labels Jun 27, 2023
@mbondyra mbondyra marked this pull request as ready for review June 27, 2023 10:52
@mbondyra mbondyra requested a review from a team as a code owner June 27, 2023 10:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

stratoula
stratoula reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marta thanx! Can we also add a note on the docs here https://github.com/elastic/kibana/blob/main/docs/management/advanced-options.asciidoc?plain=1#L539

Same as I did here https://github.com/elastic/kibana/pull/130447/files#diff-0547b43881d31a653a9fe0e54979e5008897054525b60ea900a2f500132f2b75R512

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 492 496 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stratoula
stratoula approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!, did a brief testing locally in Chrome!

@mbondyra mbondyra merged commit b87c05f into elastic:main Jun 27, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 27, 2023
@lcawl lcawl mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Time axis] Deprecate the legacy time axis
5 participants
@mbondyra @elasticmachine @kibana-ci @stratoula @kibanamachine