[UnifiedFieldList] Convert from a plugin into a package

[jughosta]

• Closes [UnifiedFieldList] Convert UnifiedFieldList plugin into a package #149336

Summary

This PR converts unifiedFieldList plugin into a new @kbn/unified-field-list package.

Had to also move some deps:

• from uiActions plugin to the existing @kbn/ui-actions-browser package
• from data plugin to a new @kbn/data-service package

Please test that Field Stats from the package are still working on your pages.

[davismcphee]

Tested locally in Discover and Lens and everything seems to be working as intended, LGTM 👍 Thanks for the dependency untangling too!

On a side note, adding 250kb to the async bundles does seem like a lot (although saving 50kb on page load is good), and I'm not really a fan of having to reach into src folders to save on bundle size since it makes restructuring package internals later more difficult, but as @kertal mentioned these seem to be expected consequences of migrating to packages currently.

[kertal]

On a side note, adding 250kb to the async bundles does seem like a lot (although saving 50kb on page load is good), and I'm not really a fan of having to reach into src folders to save on bundle size since it makes restructuring package internals later more difficult, but as @kertal mentioned these seem to be expected consequences of migrating to packages currently.

I do agree, there's definitely room for optimization beyond this PR, so something for optimizing the bundler where this part of the code can be a nice example for investigating it, FYI @elastic/kibana-operations
Also I assume breaking up the package in smaller packages (not in this PR of course) might reduce the size

[jughosta]

Hi @elastic/kibana-design and @elastic/apm-ui,
Could you please review the PR as codeowners when you get a chance?

[stratoula]

Visualizations team changes LGTM, I also tested annotations and I don't see any regression. Not a fan of 300KB addition on the async bundle but I know that it can't be avoided 😓

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: e93c014

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
aiops	525	566	+41
apm	1409	1457	+48
data	456	459	+3
dataVisualizer	344	348	+4
discover	465	559	+94
eventAnnotation	211	219	+8
lens	885	983	+98
ml	1743	1760	+17
unifiedFieldList	99	-	-99
visualizationUiComponents	90	114	+24
total			+238

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/data-service	-	9	+9
@kbn/ui-actions-browser	8	35	+27
@kbn/unified-field-list	-	267	+267
unifiedFieldList	270	-	-270
total			+33

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
@kbn/ui-actions-browser	0	2	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
aiops	805.3KB	833.7KB	+28.4KB
apm	3.6MB	3.6MB	+36.2KB
data	52.8KB	52.8KB	+4.0B
dataVisualizer	367.3KB	376.0KB	+8.7KB
discover	423.0KB	513.7KB	+90.7KB
eventAnnotation	116.7KB	120.6KB	+3.9KB
lens	1.2MB	1.3MB	+95.3KB
ml	3.4MB	3.4MB	+24.6KB
unifiedFieldList	48.4KB	-	-48.4KB
visualizationUiComponents	26.3KB	38.7KB	+12.3KB
total			+251.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
@kbn/unified-field-list	-	5	+5
unifiedFieldList	8	-	-8
total			-3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
aiops	6.2KB	6.1KB	-145.0B
apm	36.0KB	35.9KB	-146.0B
data	406.4KB	406.5KB	+55.0B
dataVisualizer	21.8KB	21.7KB	-146.0B
discover	29.0KB	28.9KB	-66.0B
eventAnnotation	27.7KB	27.6KB	-90.0B
lens	35.4KB	35.3KB	-88.0B
ml	73.1KB	72.9KB	-146.0B
uiActions	20.1KB	20.1KB	-4.0B
unifiedFieldList	53.1KB	-	-53.1KB
visualizationUiComponents	38.4KB	38.5KB	+37.0B
total			-53.8KB

Unknown metric groups

API count

id	before	after	diff
@kbn/data-service	-	14	+14
@kbn/ui-actions-browser	18	49	+31
@kbn/unified-field-list	-	293	+293
unifiedFieldList	296	-	-296
total			+42

async chunk count

id	before	after	diff
aiops	7	10	+3
apm	27	30	+3
discover	11	19	+8
eventAnnotation	4	5	+1
lens	14	21	+7
ml	31	34	+3
unifiedFieldList	7	-	-7
visualizationUiComponents	1	2	+1
total			+19

ESLint disabled line counts

id	before	after	diff
@kbn/unified-field-list	-	16	+16
enterpriseSearch	13	15	+2
securitySolution	416	420	+4
unifiedFieldList	18	-	-18
total			+4

References to deprecated APIs

id	before	after	diff
@kbn/unified-field-list	-	20	+20
unifiedFieldList	20	-	-20
total			-0

Total ESLint disabled count

id	before	after	diff
@kbn/unified-field-list	-	16	+16
enterpriseSearch	14	16	+2
securitySolution	497	501	+4
unifiedFieldList	18	-	-18
total			+4

History

• 💔 Build #137581 failed 56559f5
• 💔 Build #137545 failed 87dcccd
• 💔 Build #137493 failed 9e9359e
• 💔 Build #137390 failed 00aca28
• 💚 Build #137183 succeeded a2e60df

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta