-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v81.0.0 #158330
Upgrade EUI to v81.0.0 #158330
Conversation
Pinging @elastic/eui-team (EUI) |
I got a question regarding nested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visualizations team changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
security_solution/public/management
changes LGTM.
Thanks for the super thoughtful and engaged question @walterra! The concept of "block" vs "inline" content no longer has any semantic meaning as of HTML5. It's now solely a presentational aspect of CSS (see MDN docs), and there is no longer any validation or concern around a block element nested within an inline wrapper. In this case, I opted for an inline That being said, yes, an escape hatch exists via the new <EuiThemeProvider wrapperProps={{ style: { display: 'block' } }}> Or alternatively, if you're using the theme provider in a layout-sensitive context, e.g. as a flexbox or grid child, and the child of your <EuiFlexGroup>
<EuiThemeProvider colorMode="inverse" wrapperProps={{ cloneElement: true }}>
<EuiFlexItem grow={false}> {/* only this wrapper will render */}
// ...
</EuiFlexItem>
</EuiThemeProvider>
</EuiFlexGroup> I'll do another pass here on this PR for usages of |
@elasticmachine merge upstream |
`EuiBottomBar` already sets the color mode of all children to dark by default - no need to set it again around the button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presentation team changes LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ML related changes LGTM.
@cee-chen thanks for sharing all the details related to EuiThemeProvider
, great to see this gives us all necessary flexibility for edge cases!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files owned by Defend Workloads LGTM 👍
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @1Copenut |
Summary
@elastic/eui@80.0.0
⏩@elastic/eui@81.0.0
81.0.0
options.checked
to "mixed" inEuiSelectable
(#6774)Bug fixes
EuiPopover
,EuiModal
,EuiFlyout
) will correctly inherit text color from its nearestEuiThemeProvider
parent.<EuiText color="default">
is no longer needed. (#6775)Breaking changes
EuiSelectable
no longer renders adata-test-selected
attribute on its list items. Use thearia-checked
property instead (#6774)EuiThemeProvider
s now render a wrapping<span>
element in order to correctly set the inherited textcolor
of all descendants.<EuiText color="default">
is no longer needed. (#6775)