[maps] fix Maps don't display darktheme when user has dark theme enabled in profile #158219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
jsanz
approved these changes
May 23, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 23, 2023
…led in profile (elastic#158219) Fixes elastic#158050 PR updates `getIsDarkMode` to read value from theme$ instead of UiSettings, since UiSettings does not contain profile theming. Part of elastic#158201 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit bb1cf66)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 23, 2023
…e enabled in profile (#158219) (#158272) # Backport This will backport the following commits from `main` to `8.8`: - [[maps] fix Maps don't display darktheme when user has dark theme enabled in profile (#158219)](#158219) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-05-23T14:33:41Z","message":"[maps] fix Maps don't display darktheme when user has dark theme enabled in profile (#158219)\n\nFixes https://github.com/elastic/kibana/issues/158050\r\n\r\nPR updates `getIsDarkMode` to read value from theme$ instead of\r\nUiSettings, since UiSettings does not contain profile theming. Part of\r\nhttps://github.com//issues/158201\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"bb1cf6609a4cf5c8208318b803f6a7cdc0f2e913","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","Feature:Maps","v8.9.0","v8.8.1"],"number":158219,"url":"https://github.com/elastic/kibana/pull/158219","mergeCommit":{"message":"[maps] fix Maps don't display darktheme when user has dark theme enabled in profile (#158219)\n\nFixes https://github.com/elastic/kibana/issues/158050\r\n\r\nPR updates `getIsDarkMode` to read value from theme$ instead of\r\nUiSettings, since UiSettings does not contain profile theming. Part of\r\nhttps://github.com//issues/158201\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"bb1cf6609a4cf5c8208318b803f6a7cdc0f2e913"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158219","number":158219,"mergeCommit":{"message":"[maps] fix Maps don't display darktheme when user has dark theme enabled in profile (#158219)\n\nFixes https://github.com/elastic/kibana/issues/158050\r\n\r\nPR updates `getIsDarkMode` to read value from theme$ instead of\r\nUiSettings, since UiSettings does not contain profile theming. Part of\r\nhttps://github.com//issues/158201\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"bb1cf6609a4cf5c8208318b803f6a7cdc0f2e913"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
…led in profile (elastic#158219) Fixes elastic#158050 PR updates `getIsDarkMode` to read value from theme$ instead of UiSettings, since UiSettings does not contain profile theming. Part of elastic#158201 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
|
Those changes didn't make it into the latest BC8 of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158050
PR updates
getIsDarkModeto read value from theme$ instead of UiSettings, since UiSettings does not contain profile theming. Part of #158201