-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] filters - remove public so client usage #158095
Merged
shahzad31
merged 13 commits into
elastic:main
from
dominiqueclarke:fix/synthetics-filters-remove-public-so-references
May 23, 2023
Merged
[Synthetics] filters - remove public so client usage #158095
shahzad31
merged 13 commits into
elastic:main
from
dominiqueclarke:fix/synthetics-filters-remove-public-so-references
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/uptime (Team:uptime) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
dominiqueclarke
commented
May 18, 2023
…filters-remove-public-so-references
…filters-remove-public-so-references
shahzad31
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
6 tasks
…filters-remove-public-so-references
…filters-remove-public-so-references
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
Co-authored-by: shahzad31 <shahzad31comp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
enhancement
New value added to drive a business result
release_note:skip
Skip the PR/issue when compiling release notes
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v8.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #153399
Resolves the following task from the referenced issue
Removes public SO client usage for the fetching monitor filters options, by creating a new
GET
route for getting the available filters and their count.Testing
This PR affects filters on the overview and management pages. To test, create a few monitors with various combinations of configurations to filter against, for example monitor type, location, tags, and schedule. Be sure to also create a few project monitors.
Utilize the filters on both pages to test for regression.