Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] remove public SO usage from delete params flow #158046

Merged

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented May 18, 2023

Summary

Relates to #153399

Removes public SO client usage for the delete params workflow by directly calling the DELETE params api.

Addresses the following task from the related issue

Testing

  1. Navigate to Synthetics global params
  2. Create a param
  3. Delete that param
  4. Create two more params
  5. Using bulk actions, select both params and delete both params

@dominiqueclarke dominiqueclarke added enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels May 18, 2023
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner May 18, 2023 00:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.2MB 1.2MB +73.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

References to deprecated APIs

id before after diff
synthetics 115 114 -1

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@shahzad31 shahzad31 merged commit 8c1624b into elastic:main May 22, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 22, 2023
@shahzad31 shahzad31 deleted the fix/synthetics-delete-params-public-so branch May 22, 2023 11:45
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants