[Defend workflows] Replace differenceWith with xorWith and remove the helper #157966
Conversation
| @@ -95,9 +96,10 @@ export const validateResponseActionsPermissions = async ( | |||
|
|
|||
| const endpointAuthz = await securitySolution.getEndpointAuthz(); | |||
|
|
|||
| const differences = findDifferenceInArrays<ResponseAction, RuleResponseAction>( | |||
| const differences = xorWith<ResponseAction | RuleResponseAction>( | |||
There was a problem hiding this comment.
Can it infer the type ResponseAction | RuleResponseAction without explicitly providing it?
There was a problem hiding this comment.
I think it would infer the type if two arrays were of the same types, but in this case I had to specify these.
| @@ -95,9 +96,10 @@ export const validateResponseActionsPermissions = async ( | |||
|
|
|||
| const endpointAuthz = await securitySolution.getEndpointAuthz(); | |||
|
|
|||
| const differences = findDifferenceInArrays<ResponseAction, RuleResponseAction>( | |||
| const differences = xorWith<ResponseAction | RuleResponseAction>( | |||
There was a problem hiding this comment.
I like this better indeed. I was going to suggest xorWith earlier but didn't want to ask you to change too much. 🎉 Thanks for updating this. I think you should name the varaible symmetricDifference anyway. Maybe, also leave a comment above that says finds elements that are not in either array, so one doesn't have to look up the function to understand what this does.
There was a problem hiding this comment.
That was a very good point, thank you @ashokaditya :)
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @tomsonpl |
While using differenceWith we had to manually check for the empty array, otherwise it didn't return the difference. xorWith does this for us while returning the symmetric difference.